Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Widen EHScope::ClenupBitFields::FixupDepth to avoid overflowing it (P…
…R23490) It currently only takes 2048 gotos to overflow the FixupDepth bitfield, causing silent miscompilation. Apparently some parser generators run into this (see PR). I don't know that that data structure is terribly size sensitive anyway, and since there's no room to widen the bitfield, let's just use a separate word in EHCatchScope for it. Differential Revision: http://reviews.llvm.org/D21566 llvm-svn: 273434
- Loading branch information
Showing
2 changed files
with
37 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
// RUN: %clang_cc1 -O1 -disable-llvm-optzns -emit-llvm -o - %s | FileCheck %s | ||
|
||
#define M if (x) goto L1; | ||
#define M10 M M M M M M M M M M | ||
#define M100 M10 M10 M10 M10 M10 M10 M10 M10 M10 M10 | ||
#define M1000 M100 M100 M100 M100 M100 M100 M100 M100 M100 M100 | ||
|
||
void f(int x) { | ||
int h; | ||
|
||
// Many gotos to not-yet-emitted labels would cause EHScope's FixupDepth | ||
// to overflow (PR23490). | ||
M1000 M1000 M1000 | ||
|
||
if (x == 5) { | ||
// This will cause us to emit a clean-up of the stack variable. If the | ||
// FixupDepths are broken, fixups will erroneously get threaded through it. | ||
int i; | ||
} | ||
|
||
L1: | ||
return; | ||
} | ||
|
||
// CHECK-LABEL: define void @f | ||
// CHECK-NOT: cleanup |