-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[X86_32] Teach X86_32 va_arg to ignore empty structs. (#86075)
Empty structs are ignored for parameter passing purposes, but va_arg was incrementing the pointer anyway for that the size of empty struct in c++ is 1 byte, which could lead to va_list getting out of sync. Fix #86057.
- Loading branch information
Showing
2 changed files
with
27 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py | ||
// RUN: %clang_cc1 -triple i386-linux-gnu -emit-llvm -o - %s | FileCheck %s | ||
|
||
typedef struct {} empty; | ||
|
||
// CHECK-LABEL: @_Z17empty_record_testiz( | ||
// CHECK-NEXT: entry: | ||
// CHECK-NEXT: [[RESULT_PTR:%.*]] = alloca ptr, align 4 | ||
// CHECK-NEXT: [[Z_ADDR:%.*]] = alloca i32, align 4 | ||
// CHECK-NEXT: [[LIST:%.*]] = alloca ptr, align 4 | ||
// CHECK-NEXT: [[TMP:%.*]] = alloca [[STRUCT_EMPTY:%.*]], align 1 | ||
// CHECK-NEXT: store ptr [[AGG_RESULT:%.*]], ptr [[RESULT_PTR]], align 4 | ||
// CHECK-NEXT: store i32 [[Z:%.*]], ptr [[Z_ADDR]], align 4 | ||
// CHECK-NEXT: call void @llvm.va_start.p0(ptr [[LIST]]) | ||
// CHECK-NEXT: ret void | ||
// | ||
empty empty_record_test(int z, ...) { | ||
__builtin_va_list list; | ||
__builtin_va_start(list, z); | ||
return __builtin_va_arg(list, empty); | ||
} |