Skip to content

Commit

Permalink
NFC: Remove NoSideEffect traits from all ops except for ConstantOp.
Browse files Browse the repository at this point in the history
These traits are added in chapter 3 when we begin discussion optimization on the toy operations.

PiperOrigin-RevId: 274974010
  • Loading branch information
River707 authored and tensorflower-gardener committed Oct 16, 2019
1 parent a08482c commit 98f64b4
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions mlir/examples/toy/Ch2/include/toy/Ops.td
Expand Up @@ -92,7 +92,7 @@ def ConstantOp : Toy_Op<"constant", [NoSideEffect]> {
let verifier = [{ return ::verify(*this); }];
}

def AddOp : Toy_Op<"add", [NoSideEffect]> {
def AddOp : Toy_Op<"add"> {
let summary = "element-wise addition operation";
let description = [{
The "add" operation performs element-wise addition between two tensors.
Expand Down Expand Up @@ -144,7 +144,7 @@ def GenericCallOp : Toy_Op<"generic_call"> {
];
}

def MulOp : Toy_Op<"mul", [NoSideEffect]> {
def MulOp : Toy_Op<"mul"> {
let summary = "element-wise multiplication operation";
let description = [{
The "mul" operation performs element-wise multiplication between two
Expand Down Expand Up @@ -173,7 +173,7 @@ def PrintOp : Toy_Op<"print"> {
let arguments = (ins F64Tensor:$input);
}

def ReshapeOp : Toy_Op<"reshape", [NoSideEffect]> {
def ReshapeOp : Toy_Op<"reshape"> {
let summary = "tensor reshape operation";
let description = [{
Reshape operation is transforming its input tensor into a new tensor with
Expand Down Expand Up @@ -224,7 +224,7 @@ def ReturnOp : Toy_Op<"return", [Terminator, HasParent<"FuncOp">]> {
let verifier = [{ return ::verify(*this); }];
}

def TransposeOp : Toy_Op<"transpose", [NoSideEffect]> {
def TransposeOp : Toy_Op<"transpose"> {
let summary = "transpose operation";

let arguments = (ins F64Tensor:$input);
Expand Down

0 comments on commit 98f64b4

Please sign in to comment.