Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[RS4GC] Fix crash in the case that a live variable has a constant base.
Summary: Previously, RS4GC crashed in CreateGCRelocates() because it assumed that every base is also in the array of live variables, which isn't true if a live variable has a constant base. This change fixes the crash by making sure CreateGCRelocates() won't try to relocate a live variable with a constant base. This would be unnecessary anyway because anything with a constant base won't move. Reviewers: reames Subscribers: llvm-commits, sanjoy Differential Revision: http://reviews.llvm.org/D15556 llvm-svn: 256252
- Loading branch information
1 parent
c2961ab
commit 990dfa6
Showing
3 changed files
with
52 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
llvm/test/Transforms/RewriteStatepointsForGC/base-pointers-12.ll
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
; RUN: opt %s -rewrite-statepoints-for-gc -spp-print-base-pointers -S 2>&1 | FileCheck %s | ||
|
||
; CHECK: derived %select base %global | ||
|
||
@global = external addrspace(1) global i8 | ||
|
||
define i8 @test(i1 %cond) gc "statepoint-example" { | ||
%derived1 = getelementptr i8, i8 addrspace(1)* @global, i64 1 | ||
%derived2 = getelementptr i8, i8 addrspace(1)* @global, i64 2 | ||
%select = select i1 %cond, i8 addrspace(1)* %derived1, i8 addrspace(1)* %derived2 | ||
%safepoint_token = call i32 (i64, i32, void ()*, i32, i32, ...) @llvm.experimental.gc.statepoint.p0f_isVoidf(i64 2882400000, i32 0, void ()* @extern, i32 0, i32 0, i32 0, i32 0) | ||
; CHECK-NOT: relocate | ||
; CHECK: %load = load i8, i8 addrspace(1)* %select | ||
%load = load i8, i8 addrspace(1)* %select | ||
ret i8 %load | ||
} | ||
|
||
declare void @extern() gc "statepoint-example" | ||
|
||
declare i32 @llvm.experimental.gc.statepoint.p0f_isVoidf(i64, i32, void ()*, i32, i32, ...) |
19 changes: 19 additions & 0 deletions
19
llvm/test/Transforms/RewriteStatepointsForGC/base-pointers-13.ll
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
; RUN: opt %s -rewrite-statepoints-for-gc -spp-print-base-pointers -S 2>&1 | FileCheck %s | ||
|
||
; CHECK: derived %derived base %global | ||
|
||
@global = external addrspace(1) global i8 | ||
|
||
define i8 @test(i64 %offset) gc "statepoint-example" { | ||
%derived = getelementptr i8, i8 addrspace(1)* @global, i64 %offset | ||
%safepoint_token = call i32 (i64, i32, void ()*, i32, i32, ...) @llvm.experimental.gc.statepoint.p0f_isVoidf(i64 2882400000, i32 0, void ()* @extern, i32 0, i32 0, i32 0, i32 0) | ||
; CHECK-NOT: relocate | ||
; CHECK-NOT: remat | ||
; CHECK: %load = load i8, i8 addrspace(1)* %derived | ||
%load = load i8, i8 addrspace(1)* %derived | ||
ret i8 %load | ||
} | ||
|
||
declare void @extern() gc "statepoint-example" | ||
|
||
declare i32 @llvm.experimental.gc.statepoint.p0f_isVoidf(i64, i32, void ()*, i32, i32, ...) |