Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[InstrProf] Fix promoter when using counter relocations
When using counter relocations, two instructions are emitted to compute the address of the counter variable. ``` %BiasAdd = add i64 ptrtoint <__profc_>, <__llvm_profile_counter_bias> %Addr = inttoptr i64 %BiasAdd to i64* ``` When promoting a counter, these instructions might not be available in the block, so we need to copy these instructions. This fixes #55125 Reviewed By: phosek Differential Revision: https://reviews.llvm.org/D125710
- Loading branch information
Showing
2 changed files
with
45 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
llvm/test/Transforms/PGOProfile/counter_promo_with_bias.ll
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
; RUN: opt < %s -instrprof -runtime-counter-relocation -do-counter-promotion=true -S | FileCheck %s | ||
|
||
target triple = "x86_64-unknown-linux-gnu" | ||
|
||
@__profn_foo = private constant [3 x i8] c"foo" | ||
|
||
define void @foo(i1 %c) { | ||
entry: | ||
; CHECK: %[[BIAS:[0-9]+]] = load i64, i64* @__llvm_profile_counter_bias | ||
br label %while.cond | ||
|
||
while.cond: ; preds = %land.rhs, %while.cond.preheader | ||
; CHECK: %[[COUNT:[a-z0-9.]+]] = phi i64 [ %[[LAND_COUNT:[0-9]+]], %land.rhs ], [ 0, %entry ] | ||
br i1 %c, label %while.cond.cleanup_crit_edge, label %land.rhs | ||
|
||
while.cond.cleanup_crit_edge: ; preds = %while.cond | ||
; CHECK: %[[COUNTER_PTR:[0-9]+]] = add i64 ptrtoint ([1 x i64]* @__profc_foo to i64), %[[BIAS]] | ||
; CHECK: %[[COUNTER_ADDR:[0-9]+]] = inttoptr i64 %[[COUNTER_PTR]] to i64* | ||
; CHECK: %[[COUNTER_PROMO:[a-z0-9.]+]] = load i64, i64* %[[COUNTER_ADDR]] | ||
; CHECK: %[[VALUE:[0-9]+]] = add i64 %[[COUNTER_PROMO]], %[[COUNT]] | ||
; CHECK: store i64 %[[VALUE]], i64* %[[COUNTER_ADDR]] | ||
br label %cleanup | ||
|
||
land.rhs: ; preds = %while.cond | ||
call void @llvm.instrprof.increment(i8* getelementptr inbounds ([3 x i8], [3 x i8]* @__profn_foo, i32 0, i32 0), i64 0, i32 1, i32 0) | ||
; CHECK: %[[LAND_COUNT]] = add i64 %[[COUNT]], 1 | ||
br label %while.cond | ||
|
||
cleanup: ; preds = %while.cond.cleanup_crit_edge | ||
ret void | ||
} | ||
|
||
declare void @llvm.instrprof.increment(i8 *, i64, i32, i32) |