Skip to content

Commit

Permalink
[llvm] Remove out-of-date fixme from SmallVectorMemoryBuffer
Browse files Browse the repository at this point in the history
This fixme first appeared in the codebase with the introduction of `ObjectMemoryBuffer` in rG93de2a12a36feaf1e6d8ff28c76db9b6cda4e844, but the constructor appears to never have been templated.

Reviewed By: dexonsmith

Differential Revision: https://reviews.llvm.org/D115044
  • Loading branch information
jansvoboda11 committed Dec 8, 2021
1 parent 5b6c083 commit 9b914aa
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions llvm/include/llvm/Support/SmallVectorMemoryBuffer.h
Expand Up @@ -30,12 +30,6 @@ class SmallVectorMemoryBuffer : public MemoryBuffer {
public:
/// Construct an SmallVectorMemoryBuffer from the given SmallVector
/// r-value.
///
/// FIXME: It'd be nice for this to be a non-templated constructor taking a
/// SmallVectorImpl here instead of a templated one taking a SmallVector<N>,
/// but SmallVector's move-construction/assignment currently only take
/// SmallVectors. If/when that is fixed we can simplify this constructor and
/// the following one.
SmallVectorMemoryBuffer(SmallVectorImpl<char> &&SV)
: SV(std::move(SV)), BufferName("<in-memory object>") {
init(this->SV.begin(), this->SV.end(), false);
Expand Down

0 comments on commit 9b914aa

Please sign in to comment.