Skip to content

Commit

Permalink
[AArch64] Use dwarf exception handling on MinGW
Browse files Browse the repository at this point in the history
Ideally we should probably produce WinEH here as well, but until
then, we can use dwarf exceptions, without any further changes
required in clang, libunwind or libcxxabi.

Differential Revision: https://reviews.llvm.org/D39535

llvm-svn: 317304
  • Loading branch information
mstorsjo committed Nov 3, 2017
1 parent f5e72b5 commit 9befcd7
Show file tree
Hide file tree
Showing 3 changed files with 47 additions and 1 deletion.
4 changes: 3 additions & 1 deletion llvm/lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -106,13 +106,15 @@ AArch64MCAsmInfoCOFF::AArch64MCAsmInfoCOFF() {
PrivateLabelPrefix = ".L";
AlignmentIsInBytes = false;
SupportsDebugInformation = true;
ExceptionsType = ExceptionHandling::WinEH;
CodePointerSize = 8;
}

AArch64MCAsmInfoMicrosoftCOFF::AArch64MCAsmInfoMicrosoftCOFF() {
CommentString = ";";
ExceptionsType = ExceptionHandling::WinEH;
}

AArch64MCAsmInfoGNUCOFF::AArch64MCAsmInfoGNUCOFF() {
CommentString = "//";
ExceptionsType = ExceptionHandling::DwarfCFI;
}
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,15 @@ class AArch64WinCOFFStreamer : public MCWinCOFFStreamer {
std::unique_ptr<MCCodeEmitter> CE,
raw_pwrite_stream &OS)
: MCWinCOFFStreamer(C, std::move(AB), std::move(CE), OS) {}

void FinishImpl() override;
};

void AArch64WinCOFFStreamer::FinishImpl() {
EmitFrames(nullptr);

MCWinCOFFStreamer::FinishImpl();
}
} // end anonymous namespace

namespace llvm {
Expand Down
36 changes: 36 additions & 0 deletions llvm/test/CodeGen/AArch64/dwarf-cfi.ll
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
; RUN: llc -mtriple aarch64-windows-gnu -filetype=asm -o - %s | FileCheck %s

define void @_Z1gv() personality i8* bitcast (i32 (...)* @__gxx_personality_v0 to i8*) {
entry:
invoke void @_Z1fv()
to label %try.cont unwind label %lpad

lpad:
%0 = landingpad { i8*, i32 }
catch i8* null
%1 = extractvalue { i8*, i32 } %0, 0
%2 = tail call i8* @__cxa_begin_catch(i8* %1) #2
tail call void @__cxa_end_catch()
br label %try.cont

try.cont:
ret void
}

declare void @_Z1fv()

declare i32 @__gxx_personality_v0(...)

declare i8* @__cxa_begin_catch(i8*)

declare void @__cxa_end_catch()

; CHECK-LABEL: _Z1gv:
; CHECK: .cfi_startproc
; CHECK: .cfi_personality 0, __gxx_personality_v0
; CHECK: .cfi_lsda 0, .Lexception0
; CHECK: str x30, [sp, #-16]!
; CHECK: .cfi_def_cfa_offset 16
; CHECK: .cfi_offset w30, -16
; CHECK: ldr x30, [sp], #16
; CHECK: .cfi_endproc

0 comments on commit 9befcd7

Please sign in to comment.