Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Recommit "[lldb/API] Overwrite variables with SBLaunchInfo::SetEnviro…
…nment(append=true)" The patch was reverted 27d52cd because of failures in TestWeakSymbols.py. These have now been addressed in D83552. The original commit message was: This function was documented to overwrite entries with D76111, which was adding a couple of similar functions. However, this function (unlike the functions added in that patch) was/is not actually overwriting variables -- any pre-existing variables would get ignored. This behavior does not seem to be intentional. In fact, before the refactor in D41359, this function could introduce duplicate entries, which could have very surprising effects both inside lldb and on other applications (some applications would take the first value, some the second one; in lldb, attempting to unset a variable could make the second variable become active, etc.). Overwriting seems to be the most reasonable behavior here, so change the code to match documentation. Differential Revision: https://reviews.llvm.org/D83306
- Loading branch information