Skip to content

Commit

Permalink
[lldb] [Process/FreeBSD] Ensure that errors are always handled
Browse files Browse the repository at this point in the history
Ensure that the llvm::Error instances are always considered handled
by replacing LLDB_LOG with LLDB_LOG_ERROR.

Differential Revision: https://reviews.llvm.org/D96558
  • Loading branch information
mgorny committed Feb 16, 2021
1 parent ba2aa5f commit 9f38001
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -213,8 +213,9 @@ void NativeProcessFreeBSD::MonitorSIGTRAP(lldb::pid_t pid) {
llvm::Error error = t.CopyWatchpointsFrom(
static_cast<NativeThreadFreeBSD &>(*GetCurrentThread()));
if (error) {
LLDB_LOG(log, "failed to copy watchpoints to new thread {0}: {1}",
info.pl_lwpid, llvm::toString(std::move(error)));
LLDB_LOG_ERROR(log, std::move(error),
"failed to copy watchpoints to new thread {1}: {0}",
info.pl_lwpid);
SetState(StateType::eStateInvalid);
return;
}
Expand Down

0 comments on commit 9f38001

Please sign in to comment.