-
Notifications
You must be signed in to change notification settings - Fork 11.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[mlir][LLVM] Introduce verfier for call debug locations
This commit introduces a debug location verifier for the LLVM dialect's call operation. LLVM does not allow calls to have no debug location when they reference an inlinable function with debug information. This apparenlty breaks assumptions of LLVM's inliner. So far, there was a hack in the LLVM export that avoided this case to be triggered, but that hack causes issues when debug intrinsics are involved. Link to the revision that inroduced the export hack: https://reviews.llvm.org/D88135 LLVM's verifier as a reference: https://github.com/llvm/llvm-project/blob/2df05cd01c17f3ef720e554dc7cde43df27e5224/llvm/lib/IR/Verifier.cpp#L3546 Reviewed By: gysit, zero9178 Differential Revision: https://reviews.llvm.org/D157096
- Loading branch information
Showing
3 changed files
with
62 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
// RUN: not mlir-opt %s -split-input-file 2>&1 | FileCheck %s | ||
|
||
// This test is in a separate file because the location tracking of verify | ||
// diagnostics does not work for unknown locations. | ||
|
||
#di_file = #llvm.di_file<"file.cpp" in "/folder/"> | ||
#di_compile_unit = #llvm.di_compile_unit< | ||
sourceLanguage = DW_LANG_C_plus_plus_14, file = #di_file, | ||
isOptimized = true, emissionKind = Full | ||
> | ||
#di_subprogram = #llvm.di_subprogram< | ||
compileUnit = #di_compile_unit, scope = #di_file, | ||
name = "missing_debug_loc", file = #di_file, | ||
subprogramFlags = "Definition|Optimized" | ||
> | ||
#di_subprogram1 = #llvm.di_subprogram< | ||
compileUnit = #di_compile_unit, scope = #di_file, | ||
name = "invalid_call_debug_locs", file = #di_file, | ||
subprogramFlags = "Definition|Optimized" | ||
> | ||
#loc = loc(unknown) | ||
#loc1 = loc("file.cpp":24:0) | ||
#loc2 = loc(fused<#di_subprogram>[#loc1]) | ||
#loc3 = loc("file.cpp":42:0) | ||
#loc4 = loc(fused<#di_subprogram1>[#loc3]) | ||
|
||
llvm.func @missing_debug_loc() { | ||
llvm.return | ||
} loc(#loc2) | ||
|
||
llvm.func @invalid_call_debug_locs() { | ||
// CHECK: <unknown>:0: error: inlinable function call in a function with a DISubprogram location must have a debug location | ||
llvm.call @missing_debug_loc() : () -> () loc(#loc) | ||
llvm.return | ||
} loc(#loc4) |