Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Folding compares with unescaped allocations
Summary: If we know that the pointer allocated within a function does not escape, we can fold away comparisons that are done with global pointers Patch by Anna Thomas! Reviewers: reames, majnemer, sanjoy Subscribers: mgrang, mcrosier, majnemer, llvm-commits Differential Revision: http://reviews.llvm.org/D19276 llvm-svn: 267035
- Loading branch information
Showing
2 changed files
with
56 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
; RUN: opt -instcombine -S < %s | FileCheck %s | ||
|
||
@gp = global i32* null, align 8 | ||
|
||
declare i8* @malloc(i64) #1 | ||
|
||
define i1 @compare_global_trivialeq() { | ||
%m = call i8* @malloc(i64 4) | ||
%bc = bitcast i8* %m to i32* | ||
%lgp = load i32*, i32** @gp, align 8 | ||
%cmp = icmp eq i32* %bc, %lgp | ||
ret i1 %cmp | ||
; CHECK-LABEL: compare_global_trivialeq | ||
; CHECK: ret i1 false | ||
} | ||
|
||
define i1 @compare_global_trivialne() { | ||
%m = call i8* @malloc(i64 4) | ||
%bc = bitcast i8* %m to i32* | ||
%lgp = load i32*, i32** @gp, align 8 | ||
%cmp = icmp ne i32* %bc, %lgp | ||
ret i1 %cmp | ||
; CHECK-LABEL: compare_global_trivialne | ||
; CHECK: ret i1 true | ||
} | ||
|
||
|
||
; Although the %m is marked nocapture in the deopt operand in call to function f, | ||
; we cannot remove the alloc site: call to malloc | ||
; FIXME: The comparison should fold to false irrespective of whether the call to malloc can be elided or not | ||
declare void @f() | ||
define i32 @compare_and_call_with_deopt() { | ||
; CHECK-LABEL: compare_and_call_with_deopt | ||
%m = call i8* @malloc(i64 24) | ||
%bc = bitcast i8* %m to i32* | ||
%lgp = load i32*, i32** @gp, align 8 | ||
%cmp = icmp eq i32* %bc, %lgp | ||
%rt = zext i1 %cmp to i32 | ||
tail call void @f() [ "deopt"(i8* %m) ] | ||
ret i32 %rt | ||
; CHECK: ret i32 %rt | ||
} |