Skip to content

Commit

Permalink
[wasm-ld] Switch to xxh3_64bits
Browse files Browse the repository at this point in the history
Similar to recent changes to ELF (e.g., D154813), Mach-O, and COFF to
improve hashing performance.

Reviewed By: dschuff

Differential Revision: https://reviews.llvm.org/D155752
  • Loading branch information
MaskRay committed Jul 20, 2023
1 parent 8e0715e commit a3622ac
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions lld/test/wasm/build-id.test
Expand Up @@ -43,8 +43,8 @@ foo:


# DEFAULT: Contents of section build_id:
# DEFAULT-NEXT: 0000 10cdbf99 f76b1f5e ebb2f36a 1bde1d6c .....k.^...j...l
# DEFAULT-NEXT: 0010 01
# DEFAULT-NEXT: 0000 100e228e 4e2fa853 6393b43d ed1d4676
# DEFAULT-NEXT: 0010 13 .

# SHA1: Contents of section build_id:
# SHA1-NEXT: 0000 14ad22e8 54d72438 94af85de 3c5592bd ..".T.$8....<U..
Expand Down
2 changes: 1 addition & 1 deletion lld/wasm/InputChunks.cpp
Expand Up @@ -451,7 +451,7 @@ void MergeInputChunk::splitStrings(ArrayRef<uint8_t> data) {
fatal(toString(this) + ": string is not null terminated");
size_t size = end + 1;

pieces.emplace_back(off, xxHash64(s.substr(0, size)), true);
pieces.emplace_back(off, xxh3_64bits(s.substr(0, size)), true);
s = s.substr(size);
off += size;
}
Expand Down
2 changes: 1 addition & 1 deletion lld/wasm/Writer.cpp
Expand Up @@ -290,7 +290,7 @@ void Writer::writeBuildId() {
case BuildIdKind::Fast: {
std::vector<uint8_t> fileHash(8);
computeHash(fileHash, buf, [](uint8_t *dest, ArrayRef<uint8_t> arr) {
support::endian::write64le(dest, xxHash64(arr));
support::endian::write64le(dest, xxh3_64bits(arr));
});
makeUUID(5, fileHash, buildId);
break;
Expand Down

0 comments on commit a3622ac

Please sign in to comment.