-
Notifications
You must be signed in to change notification settings - Fork 11k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[clang][cmake] Rearrange top-level CMakeLists.txt for D116492
In that revision, I make LLD match Clang in deprecating `llvm-config`. This patch isn't to worthwhile on its own --- there isn't a sense in which the new order is "better" in isolation --- but by putting the steps that LLD also neeeds to do first, I make the diff between LLD and Clang's top-level `CMakeLists.txt` very legible. Longer term I hope: 1. We can remove calling `llvm-config` altogether, and just go strait to finding the CMake config file. This is what Flang does, at least. 2. Hopefully the diffable part is smaller then --- i.e. there is less duplicated boilerplate. 3. Any duplicate boilerplate that remains can be factored out. I didn't both trying to factor anything out in e.g. the top level common CMake Utility modules because this deprecated-but-not-removed state is a merely transitional. Reviewed By: beanz Differential Revision: https://reviews.llvm.org/D116548
- Loading branch information
1 parent
a44ef99
commit a3ab2c9
Showing
1 changed file
with
24 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters