Skip to content

Commit

Permalink
[SE] Remove Utils directory
Browse files Browse the repository at this point in the history
Summary:
There is no purpose in splitting out the Error class from the rest of
the StreamExecutor code. This organization was just a vestige of an old
failed design.

Plus, this change fixes a bug in the build where the utilites library
was not being statically linked in with libstreamexecutor.

Reviewers: jlebar, jprice

Subscribers: beanz, parallel_libs-commits

Differential Revision: https://reviews.llvm.org/D24434

llvm-svn: 281118
  • Loading branch information
henline committed Sep 9, 2016
1 parent 124384f commit a3ad6dc
Show file tree
Hide file tree
Showing 11 changed files with 12 additions and 19 deletions.
Expand Up @@ -17,9 +17,9 @@

#include <type_traits>

#include "streamexecutor/Error.h"
#include "streamexecutor/KernelSpec.h"
#include "streamexecutor/PlatformDevice.h"
#include "streamexecutor/Utils/Error.h"

namespace streamexecutor {

Expand Down
Expand Up @@ -32,7 +32,7 @@
#include <cassert>
#include <cstddef>

#include "streamexecutor/Utils/Error.h"
#include "streamexecutor/Error.h"

namespace streamexecutor {

Expand Down
Expand Up @@ -160,8 +160,8 @@
///
//===----------------------------------------------------------------------===//

#ifndef STREAMEXECUTOR_UTILS_ERROR_H
#define STREAMEXECUTOR_UTILS_ERROR_H
#ifndef STREAMEXECUTOR_ERROR_H
#define STREAMEXECUTOR_ERROR_H

#include <cstdio>
#include <cstdlib>
Expand Down Expand Up @@ -212,4 +212,4 @@ void dieIfError(Error &&E);

} // namespace streamexecutor

#endif // STREAMEXECUTOR_UTILS_ERROR_H
#endif // STREAMEXECUTOR_ERROR_H
Expand Up @@ -21,8 +21,8 @@
#ifndef STREAMEXECUTOR_KERNEL_H
#define STREAMEXECUTOR_KERNEL_H

#include "streamexecutor/Error.h"
#include "streamexecutor/KernelSpec.h"
#include "streamexecutor/Utils/Error.h"

#include <memory>

Expand Down
Expand Up @@ -18,7 +18,7 @@
#ifndef STREAMEXECUTOR_PLATFORM_H
#define STREAMEXECUTOR_PLATFORM_H

#include "streamexecutor/Utils/Error.h"
#include "streamexecutor/Error.h"

namespace streamexecutor {

Expand Down
Expand Up @@ -20,10 +20,10 @@
#define STREAMEXECUTOR_PLATFORMDEVICE_H

#include "streamexecutor/DeviceMemory.h"
#include "streamexecutor/Error.h"
#include "streamexecutor/Kernel.h"
#include "streamexecutor/LaunchDimensions.h"
#include "streamexecutor/PackedKernelArgumentArray.h"
#include "streamexecutor/Utils/Error.h"

namespace streamexecutor {

Expand Down
Expand Up @@ -21,8 +21,8 @@

#include <map>

#include "streamexecutor/Error.h"
#include "streamexecutor/Platform.h"
#include "streamexecutor/Utils/Error.h"

namespace streamexecutor {

Expand Down
Expand Up @@ -35,11 +35,11 @@
#include <string>

#include "streamexecutor/DeviceMemory.h"
#include "streamexecutor/Error.h"
#include "streamexecutor/Kernel.h"
#include "streamexecutor/LaunchDimensions.h"
#include "streamexecutor/PackedKernelArgumentArray.h"
#include "streamexecutor/PlatformDevice.h"
#include "streamexecutor/Utils/Error.h"

#include "llvm/ADT/Optional.h"
#include "llvm/ADT/Twine.h"
Expand Down
6 changes: 1 addition & 5 deletions parallel-libs/streamexecutor/lib/CMakeLists.txt
Expand Up @@ -3,22 +3,18 @@ macro(add_se_library name)
set_target_properties(${name} PROPERTIES FOLDER "streamexecutor libraries")
endmacro(add_se_library)

add_subdirectory(Utils)

add_se_library(
streamexecutor
Device.cpp
DeviceMemory.cpp
Error.cpp
Kernel.cpp
KernelSpec.cpp
PackedKernelArgumentArray.cpp
Platform.cpp
PlatformDevice.cpp
PlatformManager.cpp
Stream.cpp

LINK_LIBS
utils
)

install(TARGETS streamexecutor DESTINATION lib)
Expand Up @@ -12,7 +12,7 @@
///
//===----------------------------------------------------------------------===//

#include "streamexecutor/Utils/Error.h"
#include "streamexecutor/Error.h"

#include "llvm/ADT/StringRef.h"

Expand Down
3 changes: 0 additions & 3 deletions parallel-libs/streamexecutor/lib/Utils/CMakeLists.txt

This file was deleted.

0 comments on commit a3ad6dc

Please sign in to comment.