[mlir] use raw function pointer instead of std::function

Accessing the target of std::function apparently requires RTTI, use a raw pointer instead.
llvm · Oct 11, 2022 · a609f56 · a609f56
1 parent 6547565
commit a609f56
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/mlir/include/mlir/Dialect/Transform/IR/TransformDialect.h b/mlir/include/mlir/Dialect/Transform/IR/TransformDialect.h
@@ -212,7 +212,7 @@ void TransformDialect::addTypeIfNotRegistered() {
   auto [it, inserted] = typeParsingHooks.try_emplace(mnemonic, Type::parse);
   if (!inserted) {
     const ExtensionTypeParsingHook &parsingHook = it->getValue();
-    if (*parsingHook.target<mlir::Type (*)(AsmParser &)>() != &Type::parse)
+    if (parsingHook != &Type::parse)
       reportDuplicateTypeRegistration(mnemonic);
     else
       return;

diff --git a/mlir/include/mlir/Dialect/Transform/IR/TransformDialect.td b/mlir/include/mlir/Dialect/Transform/IR/TransformDialect.td
@@ -324,8 +324,7 @@ def Transform_Dialect : Dialect {
 
       /// Parser callback for an individual type registered by this dialect or
       /// its extensions.
-      using ExtensionTypeParsingHook =
-          std::function<::mlir::Type (::mlir::AsmParser &)>;
+      using ExtensionTypeParsingHook = ::mlir::Type (*)(::mlir::AsmParser &);
 
       /// Printer callback for an individual type registered by this dialect or
       /// its extensions.