-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[clang] Add some CodeGen tests for CWG 1xx issues (#80338)
Covers CWG issues [124](https://cplusplus.github.io/CWG/issues/124.html) [185](https://cplusplus.github.io/CWG/issues/185.html), [193](https://cplusplus.github.io/CWG/issues/193.html), [199](https://cplusplus.github.io/CWG/issues/199.html). I also looked at [190](https://cplusplus.github.io/CWG/issues/190.html), but concluded that we should try to test it via C++20 `std::is_layout_compatible` first. I tried to group tests under `dr1xx-codegen.cpp`, but found out that CodeGen can arbitrarily reorder function definitions in LLVM module. In particular, interleaving between regular function definitions and destructor definitions present in the source might not be preserved, which messes up FileCheck directives. `CHECK-DAG` can help with that, but its interaction with `CHECK-LABEL` (lack of thereof) would require me to relax tests too much.
- Loading branch information
Showing
6 changed files
with
169 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| // RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -disable-llvm-passes -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -disable-llvm-passes -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++14 %s -triple x86_64-linux-gnu -emit-llvm -disable-llvm-passes -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++17 %s -triple x86_64-linux-gnu -emit-llvm -disable-llvm-passes -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++20 %s -triple x86_64-linux-gnu -emit-llvm -disable-llvm-passes -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++23 %s -triple x86_64-linux-gnu -emit-llvm -disable-llvm-passes -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++2c %s -triple x86_64-linux-gnu -emit-llvm -disable-llvm-passes -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
|
|
||
| #if __cplusplus == 199711L | ||
| #define NOTHROW throw() | ||
| #else | ||
| #define NOTHROW noexcept(true) | ||
| #endif | ||
|
|
||
| namespace dr124 { // dr124: 2.7 | ||
|
|
||
| extern void full_expr_fence() NOTHROW; | ||
|
|
||
| struct A { | ||
| A() NOTHROW {} | ||
| ~A() NOTHROW {} | ||
| }; | ||
|
|
||
| struct B { | ||
| B(A = A()) NOTHROW {} | ||
| ~B() NOTHROW {} | ||
| }; | ||
|
|
||
| void f() { | ||
| full_expr_fence(); | ||
| B b[2]; | ||
| full_expr_fence(); | ||
| } | ||
|
|
||
| // CHECK-LABEL: define {{.*}} void @dr124::f()() | ||
| // CHECK: call void @dr124::full_expr_fence() | ||
| // CHECK: br label %arrayctor.loop | ||
| // CHECK-LABEL: arrayctor.loop: | ||
| // CHECK: call void @dr124::A::A() | ||
| // CHECK: call void @dr124::B::B(dr124::A) | ||
| // CHECK: call void @dr124::A::~A() | ||
| // CHECK: br {{.*}}, label %arrayctor.cont, label %arrayctor.loop | ||
| // CHECK-LABEL: arrayctor.cont: | ||
| // CHECK: call void @dr124::full_expr_fence() | ||
| // CHECK: br label %arraydestroy.body | ||
| // CHECK-LABEL: arraydestroy.body: | ||
| // CHECK: call void @dr124::B::~B() | ||
| // CHECK-LABEL: } | ||
|
|
||
|
|
||
| } // namespace dr124 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| // RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++14 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++17 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++20 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++23 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++2c %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
|
|
||
| namespace dr185 { // dr185: 2.7 | ||
| struct A { | ||
| mutable int value; | ||
| explicit A(int i) : value(i) {} | ||
| void mutate(int i) const { value = i; } | ||
| }; | ||
|
|
||
| int foo() { | ||
| A const& t = A(1); | ||
| A n(t); | ||
| t.mutate(2); | ||
| return n.value; | ||
| } | ||
|
|
||
| // CHECK-LABEL: define {{.*}} i32 @dr185::foo() | ||
| // CHECK: call void @dr185::A::A(int)(ptr {{[^,]*}} %ref.tmp, {{.*}}) | ||
| // CHECK: store ptr %ref.tmp, ptr %t | ||
| // CHECK-NOT: %t = | ||
| // CHECK: [[DR185_T:%.+]] = load ptr, ptr %t | ||
| // CHECK: call void @llvm.memcpy.p0.p0.i64(ptr {{[^,]*}} %n, ptr {{[^,]*}} [[DR185_T]], {{.*}}) | ||
| // CHECK-LABEL: } | ||
| } // namespace dr185 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| // RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++14 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++17 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++20 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++23 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++2c %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
|
|
||
| #if __cplusplus == 199711L | ||
| #define NOTHROW throw() | ||
| #else | ||
| #define NOTHROW noexcept(true) | ||
| #endif | ||
|
|
||
| namespace dr193 { // dr193: 2.7 | ||
| struct A { | ||
| ~A() NOTHROW {} | ||
| }; | ||
|
|
||
| struct B { | ||
| ~B() NOTHROW {} | ||
| }; | ||
|
|
||
| struct C { | ||
| ~C() NOTHROW {} | ||
| }; | ||
|
|
||
| struct D : A { | ||
| B b; | ||
| ~D() NOTHROW { C c; } | ||
| }; | ||
|
|
||
| void foo() { | ||
| D d; | ||
| } | ||
|
|
||
| // skipping over D1 (complete object destructor) | ||
| // CHECK-LABEL: define {{.*}} void @dr193::D::~D(){{.*}} | ||
| // CHECK-LABEL: define {{.*}} void @dr193::D::~D(){{.*}} | ||
| // CHECK-NOT: call void @dr193::A::~A() | ||
| // CHECK-NOT: call void @dr193::B::~B() | ||
| // CHECK: call void @dr193::C::~C() | ||
| // CHECK: call void @dr193::B::~B() | ||
| // CHECK: call void @dr193::A::~A() | ||
| // CHECK-LABEL: } | ||
| } // namespace dr193 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| // RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++14 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++17 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++20 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++23 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
| // RUN: %clang_cc1 -std=c++2c %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK | ||
|
|
||
| #if __cplusplus == 199711L | ||
| #define NOTHROW throw() | ||
| #else | ||
| #define NOTHROW noexcept(true) | ||
| #endif | ||
|
|
||
| namespace dr199 { // dr199: 2.8 | ||
| struct A { | ||
| ~A() NOTHROW {} | ||
| }; | ||
|
|
||
| struct B { | ||
| ~B() NOTHROW {} | ||
| }; | ||
|
|
||
| void foo() { | ||
| A(), B(); | ||
| } | ||
|
|
||
| // CHECK-LABEL: define {{.*}} void @dr199::foo() | ||
| // CHECK-NOT: call void @dr199::A::~A() | ||
| // CHECK: call void @dr199::B::~B() | ||
| // CHECK: call void @dr199::A::~A() | ||
| // CHECK-LABEL: } | ||
| } // namespace dr199 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters