Skip to content

Commit

Permalink
[ORC] Fix the LLJITWithRemoteDebugging example.
Browse files Browse the repository at this point in the history
This was broken by the switch from JITTargetAddress to ExecutorAddr in
21a0625.
  • Loading branch information
lhames committed Sep 28, 2021
1 parent ebe9944 commit aa061dd
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
Expand Up @@ -141,7 +141,7 @@ JITLinkExecutor::loadDylib(StringRef RemotePath) {

Expected<int> JITLinkExecutor::runAsMain(JITEvaluatedSymbol MainSym,
ArrayRef<std::string> Args) {
return EPC->runAsMain(MainSym.getAddress(), Args);
return EPC->runAsMain(ExecutorAddr(MainSym.getAddress()), Args);
}

Error JITLinkExecutor::disconnect() { return EPC->disconnect(); }
Expand Down
Expand Up @@ -340,15 +340,16 @@ class OrcRPCExecutorProcessControlBase : public ExecutorProcessControl {
Expected<int32_t> runAsMain(ExecutorAddr MainFnAddr,
ArrayRef<std::string> Args) override {
DEBUG_WITH_TYPE("orc", {
dbgs() << "Running as main: " << formatv("{0:x16}", MainFnAddr)
dbgs() << "Running as main: " << formatv("{0:x16}", MainFnAddr.getValue())
<< ", args = [";
for (unsigned I = 0; I != Args.size(); ++I)
dbgs() << (I ? "," : "") << " \"" << Args[I] << "\"";
dbgs() << "]\n";
});
auto Result = EP.template callB<orcrpctpc::RunMain>(MainFnAddr, Args);
auto Result =
EP.template callB<orcrpctpc::RunMain>(MainFnAddr.getValue(), Args);
DEBUG_WITH_TYPE("orc", {
dbgs() << " call to " << formatv("{0:x16}", MainFnAddr);
dbgs() << " call to " << formatv("{0:x16}", MainFnAddr.getValue());
if (Result)
dbgs() << " returned result " << *Result << "\n";
else
Expand All @@ -362,11 +363,11 @@ class OrcRPCExecutorProcessControlBase : public ExecutorProcessControl {
ArrayRef<char> ArgBuffer) override {
DEBUG_WITH_TYPE("orc", {
dbgs() << "Running as wrapper function "
<< formatv("{0:x16}", WrapperFnAddr) << " with "
<< formatv("{0:x16}", WrapperFnAddr.getValue()) << " with "
<< formatv("{0:x16}", ArgBuffer.size()) << " argument buffer\n";
});
auto Result = EP.template callB<orcrpctpc::RunWrapper>(
WrapperFnAddr,
WrapperFnAddr.getValue(),
ArrayRef<uint8_t>(reinterpret_cast<const uint8_t *>(ArgBuffer.data()),
ArgBuffer.size()));

Expand Down Expand Up @@ -412,7 +413,7 @@ class OrcRPCExecutorProcessControlBase : public ExecutorProcessControl {
private:
Error runWrapperInJIT(
std::function<Error(Expected<shared::WrapperFunctionResult>)> SendResult,
ExecutorAddr FunctionTag, std::vector<uint8_t> ArgBuffer) {
JITTargetAddress FunctionTag, std::vector<uint8_t> ArgBuffer) {

getExecutionSession().runJITDispatchHandler(
[this, SendResult = std::move(SendResult)](
Expand Down

0 comments on commit aa061dd

Please sign in to comment.