Skip to content

Commit

Permalink
[OpenMP] [OMPT] [8/8] Added lit tests for OMPT target callbacks
Browse files Browse the repository at this point in the history
Added a new target ompt mode that depends on libomptarget OMPT support.
Added tests that verify callbacks for target regions, kernel launch,
and data transfer operations. All of them should pass on amdgpu using
make check-libomptarget.

Reviewed By: jplehr

Differential Revision: https://reviews.llvm.org/D127372
  • Loading branch information
dhruvachak authored and mhalk committed Mar 17, 2023
1 parent a524248 commit acdb199
Show file tree
Hide file tree
Showing 17 changed files with 934 additions and 0 deletions.
3 changes: 3 additions & 0 deletions openmp/libomptarget/test/lit.cfg
Expand Up @@ -80,6 +80,9 @@ for feature in config.test_compiler_features:
if config.libomptarget_debug:
config.available_features.add('libomptarget-debug')

if config.has_libomptarget_ompt:
config.available_features.add('ompt')

config.available_features.add(config.libomptarget_current_target)

# Determine whether the test system supports unified memory.
Expand Down
1 change: 1 addition & 0 deletions openmp/libomptarget/test/lit.site.cfg.in
Expand Up @@ -19,6 +19,7 @@ config.libomptarget_current_target = "@CURRENT_TARGET@"
config.libomptarget_filecheck = "@OPENMP_FILECHECK_EXECUTABLE@"
config.libomptarget_not = "@OPENMP_NOT_EXECUTABLE@"
config.libomptarget_debug = @LIBOMPTARGET_DEBUG@
config.has_libomptarget_ompt = @LIBOMPTARGET_OMPT_SUPPORT@

# Let the main config do the real work.
lit_config.load_config(config, "@CMAKE_CURRENT_SOURCE_DIR@/lit.cfg")
129 changes: 129 additions & 0 deletions openmp/libomptarget/test/ompt/callbacks.h
@@ -0,0 +1,129 @@
#include <assert.h>
#include <stdlib.h>

// Tool related code below
#include <omp-tools.h>

// For EMI callbacks
ompt_id_t next_op_id = 0x8000000000000001;

// OMPT callbacks

// Synchronous callbacks
static void on_ompt_callback_device_initialize(int device_num, const char *type,
ompt_device_t *device,
ompt_function_lookup_t lookup,
const char *documentation) {
printf("Callback Init: device_num=%d type=%s device=%p lookup=%p doc=%p\n",
device_num, type, device, lookup, documentation);
}

static void on_ompt_callback_device_finalize(int device_num) {
printf("Callback Fini: device_num=%d\n", device_num);
}

static void on_ompt_callback_device_load(int device_num, const char *filename,
int64_t offset_in_file,
void *vma_in_file, size_t bytes,
void *host_addr, void *device_addr,
uint64_t module_id) {
printf("Callback Load: device_num:%d module_id:%lu filename:%s host_adddr:%p "
"device_addr:%p bytes:%lu\n",
device_num, module_id, filename, host_addr, device_addr, bytes);
}

static void on_ompt_callback_target_data_op(
ompt_id_t target_id, ompt_id_t host_op_id, ompt_target_data_op_t optype,
void *src_addr, int src_device_num, void *dest_addr, int dest_device_num,
size_t bytes, const void *codeptr_ra) {
assert(codeptr_ra != 0 && "Unexpected null codeptr");
// Both src and dest must not be null
assert((src_addr != 0 || dest_addr != 0) && "Both src and dest addr null");
printf(" Callback DataOp: target_id=%lu host_op_id=%lu optype=%d src=%p "
"src_device_num=%d "
"dest=%p dest_device_num=%d bytes=%lu code=%p\n",
target_id, host_op_id, optype, src_addr, src_device_num, dest_addr,
dest_device_num, bytes, codeptr_ra);
}

static void on_ompt_callback_target(ompt_target_t kind,
ompt_scope_endpoint_t endpoint,
int device_num, ompt_data_t *task_data,
ompt_id_t target_id,
const void *codeptr_ra) {
assert(codeptr_ra != 0 && "Unexpected null codeptr");
printf("Callback Target: target_id=%lu kind=%d endpoint=%d device_num=%d "
"code=%p\n",
target_id, kind, endpoint, device_num, codeptr_ra);
}

static void on_ompt_callback_target_submit(ompt_id_t target_id,
ompt_id_t host_op_id,
unsigned int requested_num_teams) {
printf(" Callback Submit: target_id=%lu host_op_id=%lu req_num_teams=%d\n",
target_id, host_op_id, requested_num_teams);
}

static void on_ompt_callback_target_map(ompt_id_t target_id,
unsigned int nitems, void **host_addr,
void **device_addr, size_t *bytes,
unsigned int *mapping_flags,
const void *codeptr_ra) {
printf("Target map callback is unimplemented\n");
abort();
}

static void on_ompt_callback_target_data_op_emi(
ompt_scope_endpoint_t endpoint, ompt_data_t *target_task_data,
ompt_data_t *target_data, ompt_id_t *host_op_id,
ompt_target_data_op_t optype, void *src_addr, int src_device_num,
void *dest_addr, int dest_device_num, size_t bytes,
const void *codeptr_ra) {
assert(codeptr_ra != 0 && "Unexpected null codeptr");
// Both src and dest must not be null
assert((src_addr != 0 || dest_addr != 0) && "Both src and dest addr null");
if (endpoint == ompt_scope_begin)
*host_op_id = next_op_id++;
printf(" Callback DataOp EMI: endpoint=%d optype=%d target_task_data=%p "
"(0x%lx) target_data=%p (0x%lx) host_op_id=%p (0x%lx) src=%p "
"src_device_num=%d "
"dest=%p dest_device_num=%d bytes=%lu code=%p\n",
endpoint, optype, target_task_data, target_task_data->value,
target_data, target_data->value, host_op_id, *host_op_id, src_addr,
src_device_num, dest_addr, dest_device_num, bytes, codeptr_ra);
}

static void on_ompt_callback_target_emi(ompt_target_t kind,
ompt_scope_endpoint_t endpoint,
int device_num, ompt_data_t *task_data,
ompt_data_t *target_task_data,
ompt_data_t *target_data,
const void *codeptr_ra) {
assert(codeptr_ra != 0 && "Unexpected null codeptr");
if (endpoint == ompt_scope_begin)
target_data->value = next_op_id++;
printf("Callback Target EMI: kind=%d endpoint=%d device_num=%d task_data=%p "
"(0x%lx) target_task_data=%p (0x%lx) target_data=%p (0x%lx) code=%p\n",
kind, endpoint, device_num, task_data, task_data->value,
target_task_data, target_task_data->value, target_data,
target_data->value, codeptr_ra);
}

static void on_ompt_callback_target_submit_emi(
ompt_scope_endpoint_t endpoint, ompt_data_t *target_data,
ompt_id_t *host_op_id, unsigned int requested_num_teams) {
printf(" Callback Submit EMI: endpoint=%d req_num_teams=%d target_data=%p "
"(0x%lx) host_op_id=%p (0x%lx)\n",
endpoint, requested_num_teams, target_data, target_data->value,
host_op_id, *host_op_id);
}

static void on_ompt_callback_target_map_emi(ompt_data_t *target_data,
unsigned int nitems,
void **host_addr,
void **device_addr, size_t *bytes,
unsigned int *mapping_flags,
const void *codeptr_ra) {
printf("Target map emi callback is unimplemented\n");
abort();
}
49 changes: 49 additions & 0 deletions openmp/libomptarget/test/ompt/register_both.h
@@ -0,0 +1,49 @@
#include <omp-tools.h>

// From openmp/runtime/test/ompt/callback.h
#define register_ompt_callback_t(name, type) \
do { \
type f_##name = &on_##name; \
if (ompt_set_callback(name, (ompt_callback_t)f_##name) == ompt_set_never) \
printf("0: Could not register callback '" #name "'\n"); \
} while (0)

#define register_ompt_callback(name) register_ompt_callback_t(name, name##_t)

// OMPT entry point handles
static ompt_set_callback_t ompt_set_callback = 0;

// Init functions
int ompt_initialize(ompt_function_lookup_t lookup, int initial_device_num,
ompt_data_t *tool_data) {
ompt_set_callback = (ompt_set_callback_t)lookup("ompt_set_callback");

if (!ompt_set_callback)
return 0; // failed

register_ompt_callback(ompt_callback_device_initialize);
register_ompt_callback(ompt_callback_device_finalize);
register_ompt_callback(ompt_callback_device_load);
register_ompt_callback(ompt_callback_target_data_op_emi);
register_ompt_callback(ompt_callback_target_data_op);
register_ompt_callback(ompt_callback_target);
register_ompt_callback(ompt_callback_target_emi);
register_ompt_callback(ompt_callback_target_submit);

return 1; // success
}

void ompt_finalize(ompt_data_t *tool_data) {}

#ifdef __cplusplus
extern "C" {
#endif
ompt_start_tool_result_t *ompt_start_tool(unsigned int omp_version,
const char *runtime_version) {
static ompt_start_tool_result_t ompt_start_tool_result = {&ompt_initialize,
&ompt_finalize, 0};
return &ompt_start_tool_result;
}
#ifdef __cplusplus
}
#endif
47 changes: 47 additions & 0 deletions openmp/libomptarget/test/ompt/register_emi.h
@@ -0,0 +1,47 @@
#include <omp-tools.h>

// From openmp/runtime/test/ompt/callback.h
#define register_ompt_callback_t(name, type) \
do { \
type f_##name = &on_##name; \
if (ompt_set_callback(name, (ompt_callback_t)f_##name) == ompt_set_never) \
printf("0: Could not register callback '" #name "'\n"); \
} while (0)

#define register_ompt_callback(name) register_ompt_callback_t(name, name##_t)

// OMPT entry point handles
static ompt_set_callback_t ompt_set_callback = 0;

// Init functions
int ompt_initialize(ompt_function_lookup_t lookup, int initial_device_num,
ompt_data_t *tool_data) {
ompt_set_callback = (ompt_set_callback_t)lookup("ompt_set_callback");

if (!ompt_set_callback)
return 0; // failed

register_ompt_callback(ompt_callback_device_initialize);
register_ompt_callback(ompt_callback_device_finalize);
register_ompt_callback(ompt_callback_device_load);
register_ompt_callback(ompt_callback_target_data_op_emi);
register_ompt_callback(ompt_callback_target_emi);
register_ompt_callback(ompt_callback_target_submit_emi);

return 1; // success
}

void ompt_finalize(ompt_data_t *tool_data) {}

#ifdef __cplusplus
extern "C" {
#endif
ompt_start_tool_result_t *ompt_start_tool(unsigned int omp_version,
const char *runtime_version) {
static ompt_start_tool_result_t ompt_start_tool_result = {&ompt_initialize,
&ompt_finalize, 0};
return &ompt_start_tool_result;
}
#ifdef __cplusplus
}
#endif
48 changes: 48 additions & 0 deletions openmp/libomptarget/test/ompt/register_emi_map.h
@@ -0,0 +1,48 @@
#include <omp-tools.h>

// From openmp/runtime/test/ompt/callback.h
#define register_ompt_callback_t(name, type) \
do { \
type f_##name = &on_##name; \
if (ompt_set_callback(name, (ompt_callback_t)f_##name) == ompt_set_never) \
printf("0: Could not register callback '" #name "'\n"); \
} while (0)

#define register_ompt_callback(name) register_ompt_callback_t(name, name##_t)

// OMPT entry point handles
static ompt_set_callback_t ompt_set_callback = 0;

// Init functions
int ompt_initialize(ompt_function_lookup_t lookup, int initial_device_num,
ompt_data_t *tool_data) {
ompt_set_callback = (ompt_set_callback_t)lookup("ompt_set_callback");

if (!ompt_set_callback)
return 0; // failed

register_ompt_callback(ompt_callback_device_initialize);
register_ompt_callback(ompt_callback_device_finalize);
register_ompt_callback(ompt_callback_device_load);
register_ompt_callback(ompt_callback_target_data_op_emi);
register_ompt_callback(ompt_callback_target_emi);
register_ompt_callback(ompt_callback_target_submit_emi);
register_ompt_callback(ompt_callback_target_map_emi);

return 1; // success
}

void ompt_finalize(ompt_data_t *tool_data) {}

#ifdef __cplusplus
extern "C" {
#endif
ompt_start_tool_result_t *ompt_start_tool(unsigned int omp_version,
const char *runtime_version) {
static ompt_start_tool_result_t ompt_start_tool_result = {&ompt_initialize,
&ompt_finalize, 0};
return &ompt_start_tool_result;
}
#ifdef __cplusplus
}
#endif
47 changes: 47 additions & 0 deletions openmp/libomptarget/test/ompt/register_no_device_init.h
@@ -0,0 +1,47 @@
#include <omp-tools.h>

// From openmp/runtime/test/ompt/callback.h
#define register_ompt_callback_t(name, type) \
do { \
type f_##name = &on_##name; \
if (ompt_set_callback(name, (ompt_callback_t)f_##name) == ompt_set_never) \
printf("0: Could not register callback '" #name "'\n"); \
} while (0)

#define register_ompt_callback(name) register_ompt_callback_t(name, name##_t)

// OMPT entry point handles
static ompt_set_callback_t ompt_set_callback = 0;

// Init functions
int ompt_initialize(ompt_function_lookup_t lookup, int initial_device_num,
ompt_data_t *tool_data) {
ompt_set_callback = (ompt_set_callback_t)lookup("ompt_set_callback");

if (!ompt_set_callback)
return 0; // failed

// If no device init callback is registered, the other callbacks won't be
// activated.
register_ompt_callback(ompt_callback_device_load);
register_ompt_callback(ompt_callback_target_data_op);
register_ompt_callback(ompt_callback_target);
register_ompt_callback(ompt_callback_target_submit);

return 1; // success
}

void ompt_finalize(ompt_data_t *tool_data) {}

#ifdef __cplusplus
extern "C" {
#endif
ompt_start_tool_result_t *ompt_start_tool(unsigned int omp_version,
const char *runtime_version) {
static ompt_start_tool_result_t ompt_start_tool_result = {&ompt_initialize,
&ompt_finalize, 0};
return &ompt_start_tool_result;
}
#ifdef __cplusplus
}
#endif
47 changes: 47 additions & 0 deletions openmp/libomptarget/test/ompt/register_non_emi.h
@@ -0,0 +1,47 @@
#include <omp-tools.h>

// From openmp/runtime/test/ompt/callback.h
#define register_ompt_callback_t(name, type) \
do { \
type f_##name = &on_##name; \
if (ompt_set_callback(name, (ompt_callback_t)f_##name) == ompt_set_never) \
printf("0: Could not register callback '" #name "'\n"); \
} while (0)

#define register_ompt_callback(name) register_ompt_callback_t(name, name##_t)

// OMPT entry point handles
static ompt_set_callback_t ompt_set_callback = 0;

// Init functions
int ompt_initialize(ompt_function_lookup_t lookup, int initial_device_num,
ompt_data_t *tool_data) {
ompt_set_callback = (ompt_set_callback_t)lookup("ompt_set_callback");

if (!ompt_set_callback)
return 0; // failed

register_ompt_callback(ompt_callback_device_initialize);
register_ompt_callback(ompt_callback_device_finalize);
register_ompt_callback(ompt_callback_device_load);
register_ompt_callback(ompt_callback_target_data_op);
register_ompt_callback(ompt_callback_target);
register_ompt_callback(ompt_callback_target_submit);

return 1; // success
}

void ompt_finalize(ompt_data_t *tool_data) {}

#ifdef __cplusplus
extern "C" {
#endif
ompt_start_tool_result_t *ompt_start_tool(unsigned int omp_version,
const char *runtime_version) {
static ompt_start_tool_result_t ompt_start_tool_result = {&ompt_initialize,
&ompt_finalize, 0};
return &ompt_start_tool_result;
}
#ifdef __cplusplus
}
#endif

0 comments on commit acdb199

Please sign in to comment.