Skip to content

Commit

Permalink
[clang] NFC: Use compile-time option spelling when generating command…
Browse files Browse the repository at this point in the history
… line

When generating command lines, use the option spelling generated by TableGen (`StringLiteral`) instead of constructing it at runtime. This saves some needless allocations.

Depends on D157029.

Reviewed By: benlangmuir, MaskRay

Differential Revision: https://reviews.llvm.org/D157054
  • Loading branch information
jansvoboda11 committed Aug 9, 2023
1 parent 501f92d commit acf5785
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions clang/lib/Frontend/CompilerInvocation.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -615,16 +615,15 @@ static unsigned getOptimizationLevelSize(ArgList &Args) {
static void GenerateArg(ArgumentConsumer Consumer,
llvm::opt::OptSpecifier OptSpecifier) {
Option Opt = getDriverOptTable().getOption(OptSpecifier);
denormalizeSimpleFlag(Consumer, Opt.getPrefix() + Opt.getName(),
denormalizeSimpleFlag(Consumer, Opt.getPrefixedName(),
Option::OptionClass::FlagClass, 0);
}

static void GenerateArg(ArgumentConsumer Consumer,
llvm::opt::OptSpecifier OptSpecifier,
const Twine &Value) {
Option Opt = getDriverOptTable().getOption(OptSpecifier);
denormalizeString(Consumer, Opt.getPrefix() + Opt.getName(), Opt.getKind(), 0,
Value);
denormalizeString(Consumer, Opt.getPrefixedName(), Opt.getKind(), 0, Value);
}

// Parse command line arguments into CompilerInvocation.
Expand Down

0 comments on commit acf5785

Please sign in to comment.