Skip to content

Commit

Permalink
[NVPTX] declare no vector registers
Browse files Browse the repository at this point in the history
Summary:
Without this patch, LoopVectorizer in certain cases (see loop-vectorize.ll)
produces code with complex control flow which hurts later optimizations. Since
NVPTX doesn't have vector registers in LLVM's sense
(NVPTXTTI::getRegisterBitWidth(true) == 32), we for now declare no vector
registers to effectively disable loop vectorization.

Reviewers: jholewinski

Subscribers: jingyue, llvm-commits, jholewinski

Differential Revision: http://reviews.llvm.org/D11089

llvm-svn: 241884
  • Loading branch information
Jingyue Wu committed Jul 10, 2015
1 parent c851ccc commit ad85c8c
Show file tree
Hide file tree
Showing 3 changed files with 47 additions and 0 deletions.
6 changes: 6 additions & 0 deletions llvm/lib/Target/NVPTX/NVPTXTargetTransformInfo.cpp
Expand Up @@ -117,3 +117,9 @@ unsigned NVPTXTTIImpl::getArithmeticInstrCost(
Opd1PropInfo, Opd2PropInfo);
}
}

unsigned NVPTXTTIImpl::getNumberOfRegisters(bool Vector) {
if (Vector)
return 0;
return BaseT::getNumberOfRegisters(Vector);
}
2 changes: 2 additions & 0 deletions llvm/lib/Target/NVPTX/NVPTXTargetTransformInfo.h
Expand Up @@ -58,6 +58,8 @@ class NVPTXTTIImpl : public BasicTTIImplBase<NVPTXTTIImpl> {
TTI::OperandValueKind Opd2Info = TTI::OK_AnyValue,
TTI::OperandValueProperties Opd1PropInfo = TTI::OP_None,
TTI::OperandValueProperties Opd2PropInfo = TTI::OP_None);

unsigned getNumberOfRegisters(bool Vector);
};

} // end namespace llvm
Expand Down
39 changes: 39 additions & 0 deletions llvm/test/CodeGen/NVPTX/loop-vectorize.ll
@@ -0,0 +1,39 @@
; RUN: opt < %s -O3 -S | FileCheck %s

target datalayout = "e-i64:64-v16:16-v32:32-n16:32:64"
target triple = "nvptx64-nvidia-cuda"

define void @no_vectorization(i32 %n, i32 %a, i32 %b) {
; CHECK-LABEL: no_vectorization(
; CHECK-NOT: <4 x i32>
; CHECK-NOT: <4 x i1>
entry:
%cmp.5 = icmp sgt i32 %n, 0
br i1 %cmp.5, label %for.body.preheader, label %for.cond.cleanup

for.body.preheader: ; preds = %entry
br label %for.body

for.cond.cleanup.loopexit: ; preds = %for.body
br label %for.cond.cleanup

for.cond.cleanup: ; preds = %for.cond.cleanup.loopexit, %entry
ret void

for.body: ; preds = %for.body.preheader, %for.body
%i.06 = phi i32 [ %inc, %for.body ], [ 0, %for.body.preheader ]
%add = add nsw i32 %i.06, %a
%mul = mul nsw i32 %add, %b
%cmp1 = icmp sgt i32 %mul, -1
tail call void @llvm.assume(i1 %cmp1)
%inc = add nuw nsw i32 %i.06, 1
%exitcond = icmp eq i32 %inc, %n
br i1 %exitcond, label %for.cond.cleanup.loopexit, label %for.body
}

declare void @llvm.assume(i1) #0

attributes #0 = { nounwind }

!nvvm.annotations = !{!0}
!0 = !{void (i32, i32, i32)* @no_vectorization, !"kernel", i32 1}

0 comments on commit ad85c8c

Please sign in to comment.