Skip to content

Commit

Permalink
[TTI] Add getCacheLineSize
Browse files Browse the repository at this point in the history
Summary:
And use it in PPCLoopDataPrefetch.cpp.

@hfinkel, please let me know if your preference would be to preserve the
ppc-loop-prefetch-cache-line option in order to be able to override the
value of TTI::getCacheLineSize for PPC.

Reviewers: hfinkel

Subscribers: hulx2000, mcrosier, mssimpso, hfinkel, llvm-commits

Differential Revision: http://reviews.llvm.org/D16306

llvm-svn: 258419
  • Loading branch information
anemet committed Jan 21, 2016
1 parent fcdb199 commit af76110
Show file tree
Hide file tree
Showing 6 changed files with 29 additions and 5 deletions.
7 changes: 7 additions & 0 deletions llvm/include/llvm/Analysis/TargetTransformInfo.h
Expand Up @@ -416,6 +416,9 @@ class TargetTransformInfo {
/// \return The width of the largest scalar or vector register type.
unsigned getRegisterBitWidth(bool Vector) const;

/// \return The size of a cache line in bytes.
unsigned getCacheLineSize() const;

/// \return The maximum interleave factor that any transform should try to
/// perform for this target. This number depends on the level of parallelism
/// and the number of execution units in the CPU.
Expand Down Expand Up @@ -609,6 +612,7 @@ class TargetTransformInfo::Concept {
Type *Ty) = 0;
virtual unsigned getNumberOfRegisters(bool Vector) = 0;
virtual unsigned getRegisterBitWidth(bool Vector) = 0;
virtual unsigned getCacheLineSize() = 0;
virtual unsigned getMaxInterleaveFactor(unsigned VF) = 0;
virtual unsigned
getArithmeticInstrCost(unsigned Opcode, Type *Ty, OperandValueKind Opd1Info,
Expand Down Expand Up @@ -775,6 +779,9 @@ class TargetTransformInfo::Model final : public TargetTransformInfo::Concept {
unsigned getRegisterBitWidth(bool Vector) override {
return Impl.getRegisterBitWidth(Vector);
}
unsigned getCacheLineSize() override {
return Impl.getCacheLineSize();
}
unsigned getMaxInterleaveFactor(unsigned VF) override {
return Impl.getMaxInterleaveFactor(VF);
}
Expand Down
2 changes: 2 additions & 0 deletions llvm/include/llvm/Analysis/TargetTransformInfoImpl.h
Expand Up @@ -264,6 +264,8 @@ class TargetTransformInfoImplBase {

unsigned getRegisterBitWidth(bool Vector) { return 32; }

unsigned getCacheLineSize() { return 0; }

unsigned getMaxInterleaveFactor(unsigned VF) { return 1; }

unsigned getArithmeticInstrCost(unsigned Opcode, Type *Ty,
Expand Down
4 changes: 4 additions & 0 deletions llvm/lib/Analysis/TargetTransformInfo.cpp
Expand Up @@ -215,6 +215,10 @@ unsigned TargetTransformInfo::getRegisterBitWidth(bool Vector) const {
return TTIImpl->getRegisterBitWidth(Vector);
}

unsigned TargetTransformInfo::getCacheLineSize() const {
return TTIImpl->getCacheLineSize();
}

unsigned TargetTransformInfo::getMaxInterleaveFactor(unsigned VF) const {
return TTIImpl->getMaxInterleaveFactor(VF);
}
Expand Down
8 changes: 3 additions & 5 deletions llvm/lib/Target/PowerPC/PPCLoopDataPrefetch.cpp
Expand Up @@ -50,10 +50,6 @@ static cl::opt<unsigned>
PrefDist("ppc-loop-prefetch-distance", cl::Hidden, cl::init(300),
cl::desc("The loop prefetch distance"));

static cl::opt<unsigned>
CacheLineSize("ppc-loop-prefetch-cache-line", cl::Hidden, cl::init(64),
cl::desc("The loop prefetch cache line size"));

namespace llvm {
void initializePPCLoopDataPrefetchPass(PassRegistry&);
}
Expand Down Expand Up @@ -110,6 +106,8 @@ bool PPCLoopDataPrefetch::runOnFunction(Function &F) {
AC = &getAnalysis<AssumptionCacheTracker>().getAssumptionCache(F);
TTI = &getAnalysis<TargetTransformInfoWrapperPass>().getTTI(F);

assert(TTI->getCacheLineSize() && "Cache line size is not set for target");

bool MadeChange = false;

for (auto I = LI->begin(), IE = LI->end(); I != IE; ++I)
Expand Down Expand Up @@ -193,7 +191,7 @@ bool PPCLoopDataPrefetch::runOnLoop(Loop *L) {
if (const SCEVConstant *ConstPtrDiff =
dyn_cast<SCEVConstant>(PtrDiff)) {
int64_t PD = std::abs(ConstPtrDiff->getValue()->getSExtValue());
if (PD < (int64_t) CacheLineSize) {
if (PD < (int64_t) TTI->getCacheLineSize()) {
DupPref = true;
break;
}
Expand Down
12 changes: 12 additions & 0 deletions llvm/lib/Target/PowerPC/PPCTargetTransformInfo.cpp
Expand Up @@ -21,6 +21,12 @@ using namespace llvm;
static cl::opt<bool> DisablePPCConstHoist("disable-ppc-constant-hoisting",
cl::desc("disable constant hoisting on PPC"), cl::init(false), cl::Hidden);

// This is currently only used for the data prefetch pass which is only enabled
// for BG/Q by default.
static cl::opt<unsigned>
CacheLineSize("ppc-loop-prefetch-cache-line", cl::Hidden, cl::init(64),
cl::desc("The loop prefetch cache line size"));

//===----------------------------------------------------------------------===//
//
// PPC cost model.
Expand Down Expand Up @@ -230,6 +236,12 @@ unsigned PPCTTIImpl::getRegisterBitWidth(bool Vector) {

}

unsigned PPCTTIImpl::getCacheLineSize() {
// This is currently only used for the data prefetch pass which is only
// enabled for BG/Q by default.
return CacheLineSize;
}

unsigned PPCTTIImpl::getMaxInterleaveFactor(unsigned VF) {
unsigned Directive = ST->getDarwinDirective();
// The 440 has no SIMD support, but floating-point instructions
Expand Down
1 change: 1 addition & 0 deletions llvm/lib/Target/PowerPC/PPCTargetTransformInfo.h
Expand Up @@ -70,6 +70,7 @@ class PPCTTIImpl : public BasicTTIImplBase<PPCTTIImpl> {
bool enableInterleavedAccessVectorization();
unsigned getNumberOfRegisters(bool Vector);
unsigned getRegisterBitWidth(bool Vector);
unsigned getCacheLineSize();
unsigned getMaxInterleaveFactor(unsigned VF);
int getArithmeticInstrCost(
unsigned Opcode, Type *Ty,
Expand Down

0 comments on commit af76110

Please sign in to comment.