[ELF] Rename Symbol::compare to shouldReplace. NFC

The return value is not a boolean instead of a tri-state. Suggested by Peter Smith in D120640.
llvm · Feb 28, 2022 · b07ef4d · b07ef4d
1 parent 3906ebf
commit b07ef4d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lld/ELF/Symbols.cpp b/lld/ELF/Symbols.cpp
@@ -508,7 +508,7 @@ void Symbol::resolveUndefined(const Undefined &other) {
 }
 
 // Compare two symbols. Return true if the new symbol should win.
-bool Symbol::compare(const Defined &other) const {
+bool Symbol::shouldReplace(const Defined &other) const {
   if (LLVM_UNLIKELY(isCommon())) {
     if (config->warnCommon)
       warn("common " + getName() + " is overridden");
@@ -605,7 +605,7 @@ void Symbol::resolveCommon(const CommonSymbol &other) {
 }
 
 void Symbol::resolveDefined(const Defined &other) {
-  if (compare(other))
+  if (shouldReplace(other))
     replace(other);
 }
 

diff --git a/lld/ELF/Symbols.h b/lld/ELF/Symbols.h
@@ -228,7 +228,7 @@ class Symbol {
   void resolveLazy(const LazyObject &other);
   void resolveShared(const SharedSymbol &other);
 
-  bool compare(const Defined &other) const;
+  bool shouldReplace(const Defined &other) const;
 
   inline size_t getSymbolSize() const;