Skip to content

Commit

Permalink
[OpenMP][CUDA] Add missing overload for remquo(float,float,int*)
Browse files Browse the repository at this point in the history
Reported by Colleen Bertoni <bertoni@anl.gov> after running the OvO test
suite: https://github.com/TApplencourt/OvO/

The template overload is still hidden behind an ifdef for OpenMP. In the
future we probably want to remove the ifdef but that requires further
testing.

Reviewed By: JonChesterfield, tra

Differential Revision: https://reviews.llvm.org/D89971
  • Loading branch information
jdoerfert committed Oct 28, 2020
1 parent 739d4bf commit b1a90e1
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions clang/lib/Headers/__clang_cuda_cmath.h
Expand Up @@ -174,6 +174,9 @@ __DEVICE__ float sinh(float __x) { return ::sinhf(__x); }
__DEVICE__ float sqrt(float __x) { return ::sqrtf(__x); }
__DEVICE__ float tan(float __x) { return ::tanf(__x); }
__DEVICE__ float tanh(float __x) { return ::tanhf(__x); }
__DEVICE__ float remquo(float __n, float __d, int *__q) {
return ::remquof(__n, __d, __q);
}

// Notably missing above is nexttoward. We omit it because
// libdevice doesn't provide an implementation, and we don't want to be in the
Expand Down

0 comments on commit b1a90e1

Please sign in to comment.