Skip to content

Commit

Permalink
[flang]Fix build failure in tests
Browse files Browse the repository at this point in the history
After submitting the DataLayout fix, some tests fail when they didn't
before. This has to do with the target essentially being ignored when
these tests were run earlier, as the --target x86-unknown-linux-gnu
only has to be correctly formed to be accepted.

Now the target triple is actually being used to get the targetmachine
earlier - before MLIR is generated - so the test that has a valid target
but not available on the platform fails.

Fix is to require x86 registered target when running those tests.

Reviewed By: awarzynski

Differential Revision: https://reviews.llvm.org/D137335
  • Loading branch information
Leporacanthicus committed Nov 3, 2022
1 parent 74bace2 commit b36d678
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions flang/test/Fir/boxchar.fir
@@ -1,5 +1,5 @@
// RUN: tco --target=x86_64-unknown-linux-gnu %s | FileCheck %s
// RUN: %flang_fc1 -emit-llvm -triple x86_64-unknown-linux-gnu %s -o - | FileCheck %s
// RUN: tco %s | FileCheck %s
// RUN: %flang_fc1 -emit-llvm %s -o - | FileCheck %s

// Test of building and passing boxchar.

Expand Down
4 changes: 2 additions & 2 deletions flang/test/Fir/inline.fir
@@ -1,5 +1,5 @@
// RUN: tco --target=x86_64-unknown-linux-gnu --inline-all %s -o - | FileCheck %s
// RUN: %flang_fc1 -triple x86_64-unknown-linux-gnu -mmlir --inline-all -emit-llvm %s -o - | FileCheck %s
// RUN: tco --inline-all %s -o - | FileCheck %s
// RUN: %flang_fc1 -mmlir --inline-all -emit-llvm %s -o - | FileCheck %s

// CHECK-LABEL: @add
func.func @add(%a : i32, %b : i32) -> i32 {
Expand Down

0 comments on commit b36d678

Please sign in to comment.