Skip to content

Commit

Permalink
[compiler-rt][NFC] Inclusive language: remove use of sanity check/test
Browse files Browse the repository at this point in the history
from compiler-rt/lib/tsan

[NFC] As part of using inclusive language within the llvm project, this
patch rewords comments to remove sanity check and sanity test.

Reviewed By: dvyukov

Differential Revision: https://reviews.llvm.org/D124390
  • Loading branch information
Quinn Pham authored and Quinn Pham committed Apr 25, 2022
1 parent 7714e03 commit b3e8e43
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion compiler-rt/lib/tsan/go/test.c
Expand Up @@ -6,7 +6,7 @@
//
//===----------------------------------------------------------------------===//
//
// Sanity test for Go runtime.
// Test for Go runtime.
//
//===----------------------------------------------------------------------===//

Expand Down
8 changes: 4 additions & 4 deletions compiler-rt/lib/tsan/rtl-old/CMakeLists.txt
Expand Up @@ -172,7 +172,7 @@ else()
add_asm_sources(TSAN_ASM_SOURCES
tsan_rtl_amd64.S
)
# Sanity check for Go runtime.
# Check for Go runtime.
set(BUILDGO_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/../go/buildgo.sh)
add_custom_target(GotsanRuntimeCheck
COMMAND env "CC=${CMAKE_C_COMPILER} ${CMAKE_C_COMPILER_ARG1}"
Expand All @@ -186,7 +186,7 @@ else()
add_asm_sources(TSAN_ASM_SOURCES
tsan_rtl_aarch64.S
)
# Sanity check for Go runtime.
# Check for Go runtime.
set(BUILDGO_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/../go/buildgo.sh)
add_custom_target(GotsanRuntimeCheck
COMMAND env "CC=${CMAKE_C_COMPILER} ${CMAKE_C_COMPILER_ARG1}"
Expand All @@ -200,7 +200,7 @@ else()
add_asm_sources(TSAN_ASM_SOURCES
tsan_rtl_ppc64.S
)
# Sanity check for Go runtime.
# Check for Go runtime.
set(BUILDGO_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/../go/buildgo.sh)
add_custom_target(GotsanRuntimeCheck
COMMAND env "CC=${CMAKE_C_COMPILER} ${CMAKE_C_COMPILER_ARG1}"
Expand All @@ -218,7 +218,7 @@ else()
add_asm_sources(TSAN_ASM_SOURCES
tsan_rtl_s390x.S
)
# Sanity check for Go runtime.
# Check for Go runtime.
set(BUILDGO_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/../go/buildgo.sh)
add_custom_target(GotsanRuntimeCheck
COMMAND env "CC=${CMAKE_C_COMPILER} ${CMAKE_C_COMPILER_ARG1}"
Expand Down
2 changes: 1 addition & 1 deletion compiler-rt/lib/tsan/rtl-old/tsan_flags.cpp
Expand Up @@ -97,7 +97,7 @@ void InitializeFlags(Flags *f, const char *env, const char *env_option_name) {
ubsan_parser.ParseStringFromEnv("UBSAN_OPTIONS");
#endif

// Sanity check.
// Check flags.
if (!f->report_bugs) {
f->report_thread_leaks = false;
f->report_destroy_locked = false;
Expand Down
8 changes: 4 additions & 4 deletions compiler-rt/lib/tsan/rtl/CMakeLists.txt
Expand Up @@ -169,7 +169,7 @@ else()
add_asm_sources(TSAN_ASM_SOURCES
tsan_rtl_amd64.S
)
# Sanity check for Go runtime.
# Check for Go runtime.
set(BUILDGO_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/../go/buildgo.sh)
add_custom_target(GotsanRuntimeCheck
COMMAND env "CC=${CMAKE_C_COMPILER} ${CMAKE_C_COMPILER_ARG1}"
Expand All @@ -183,7 +183,7 @@ else()
add_asm_sources(TSAN_ASM_SOURCES
tsan_rtl_aarch64.S
)
# Sanity check for Go runtime.
# Check for Go runtime.
set(BUILDGO_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/../go/buildgo.sh)
add_custom_target(GotsanRuntimeCheck
COMMAND env "CC=${CMAKE_C_COMPILER} ${CMAKE_C_COMPILER_ARG1}"
Expand All @@ -197,7 +197,7 @@ else()
add_asm_sources(TSAN_ASM_SOURCES
tsan_rtl_ppc64.S
)
# Sanity check for Go runtime.
# Check for Go runtime.
set(BUILDGO_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/../go/buildgo.sh)
add_custom_target(GotsanRuntimeCheck
COMMAND env "CC=${CMAKE_C_COMPILER} ${CMAKE_C_COMPILER_ARG1}"
Expand All @@ -215,7 +215,7 @@ else()
add_asm_sources(TSAN_ASM_SOURCES
tsan_rtl_s390x.S
)
# Sanity check for Go runtime.
# Check for Go runtime.
set(BUILDGO_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/../go/buildgo.sh)
add_custom_target(GotsanRuntimeCheck
COMMAND env "CC=${CMAKE_C_COMPILER} ${CMAKE_C_COMPILER_ARG1}"
Expand Down
2 changes: 1 addition & 1 deletion compiler-rt/lib/tsan/rtl/tsan_flags.cpp
Expand Up @@ -97,7 +97,7 @@ void InitializeFlags(Flags *f, const char *env, const char *env_option_name) {
ubsan_parser.ParseStringFromEnv("UBSAN_OPTIONS");
#endif

// Sanity check.
// Check flags.
if (!f->report_bugs) {
f->report_thread_leaks = false;
f->report_destroy_locked = false;
Expand Down
2 changes: 1 addition & 1 deletion compiler-rt/lib/tsan/rtl/tsan_rtl.cpp
Expand Up @@ -936,7 +936,7 @@ void TraceSwitchPartImpl(ThreadState* thr) {
// Pathologically large stacks may not fit into the part.
// In these cases we log only fixed number of top frames.
const uptr kMaxFrames = 1000;
// Sanity check that kMaxFrames won't consume the whole part.
// Check that kMaxFrames won't consume the whole part.
static_assert(kMaxFrames < TracePart::kSize / 2, "kMaxFrames is too big");
uptr* pos = Max(&thr->shadow_stack[0], thr->shadow_stack_pos - kMaxFrames);
for (; pos < thr->shadow_stack_pos; pos++) {
Expand Down

0 comments on commit b3e8e43

Please sign in to comment.