Skip to content

Commit

Permalink
Print out "suppoted targets".
Browse files Browse the repository at this point in the history
This is to improve compatibility with GNU Libtool that expect
/supported targets:.* elf/ in a message for the -help option.

Differential Revision: https://reviews.llvm.org/D31208

llvm-svn: 298568
  • Loading branch information
rui314 committed Mar 23, 2017
1 parent 7690721 commit b57412e
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 0 deletions.
13 changes: 13 additions & 0 deletions lld/ELF/DriverUtils.cpp
Expand Up @@ -119,6 +119,19 @@ opt::InputArgList ELFOptTable::parse(ArrayRef<const char *> Argv) {
void elf::printHelp(const char *Argv0) {
ELFOptTable Table;
Table.PrintHelp(outs(), Argv0, "lld", false);
outs() << "\n";

// Scripts generated by Libtool versions up to at least 2.4.6 (the most
// recent version as of March 2017) expect /supported targets:.* elf/ in
// a message for the -help option. If it doesn't match, the scripts
// assume that the linker doesn't support very basic features such as
// shared libraries. Therefore, we need to print out at least "elf".
// Here, we print out all the targets that we support.
outs() << Argv0 << ": supported targets: "
<< "elf32-i386 elf32-iamcu elf32-littlearm elf32-powerpc "
<< "elf32-tradbigmips elf32-tradlittlemips elf32-x86-64 "
<< "elf64-amdgpu elf64-littleaarch64 elf64-powerpc "
<< "elf64-tradbigmips elf64-tradlittlemips elf64-x86-64\n";
}

// Reconstructs command line arguments so that so that you can re-run
Expand Down
1 change: 1 addition & 0 deletions lld/test/ELF/driver.test
Expand Up @@ -15,6 +15,7 @@

# RUN: ld.lld --help 2>&1 | FileCheck -check-prefix=HELP %s
# HELP: USAGE:
# HELP: ld.lld: supported targets: {{.*}} elf

# RUN: ld.lld --version 2>&1 | FileCheck -check-prefix=VERSION %s
# VERSION: LLD {{.*}} (compatible with GNU linkers)
Expand Down

0 comments on commit b57412e

Please sign in to comment.