Skip to content

Commit

Permalink
[llvm-cxxfilt]Add test to show that empty lines can be handled
Browse files Browse the repository at this point in the history
I recently discovered a bug in llvm-cxxfilt introduced in r353743 but
was fixed later incidentally due to r355031. Specifically, llvm-cxxfilt
was attempting to call .back() on an empty string any time there was a
new line in the input. This was causing a crash in my debug builds only.
This patch simply adds a test that explicitly tests that llvm-cxxfilt
handles empty lines correctly. It may pass under release builds under
the broken behaviour, but it fails at least in debug builds.

Reviewed by: mattd

Differential Revision: https://reviews.llvm.org/D58785

llvm-svn: 355929
  • Loading branch information
jh7370 committed Mar 12, 2019
1 parent 662c043 commit b69a501
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions llvm/test/tools/llvm-cxxfilt/empty-line.test
@@ -0,0 +1,9 @@
# Show that llvm-cxxfilt can handle empty lines in the input.
RUN: echo "" > %t
RUN: echo "_Z3foov" >> %t
RUN: echo "" >> %t
RUN: llvm-cxxfilt < %t | FileCheck %s

CHECK: {{^$}}
CHECK-NEXT: foo()
CHECK-EMPTY:

0 comments on commit b69a501

Please sign in to comment.