Skip to content

Commit

Permalink
[lsan] Do not check for leaks in the forked process
Browse files Browse the repository at this point in the history
Summary:
If calling process had threads then forked process will fail to detect
references from them.

Fixes google/sanitizers#836

Reviewers: alekseyshl

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D47751

llvm-svn: 334036
  • Loading branch information
vitalybuka committed Jun 5, 2018
1 parent 8f6d6c8 commit b89704f
Show file tree
Hide file tree
Showing 2 changed files with 44 additions and 0 deletions.
9 changes: 9 additions & 0 deletions compiler-rt/lib/lsan/lsan_common.cc
Expand Up @@ -100,6 +100,8 @@ static SuppressionContext *GetSuppressionContext() {

static InternalMmapVector<RootRegion> *root_regions;

static uptr initialized_for_pid;

InternalMmapVector<RootRegion> const *GetRootRegions() { return root_regions; }

void InitializeRootRegions() {
Expand All @@ -113,6 +115,7 @@ const char *MaybeCallLsanDefaultOptions() {
}

void InitCommonLsan() {
initialized_for_pid = internal_getpid();
InitializeRootRegions();
if (common_flags()->detect_leaks) {
// Initialization which can fail or print warnings should only be done if
Expand Down Expand Up @@ -568,6 +571,12 @@ static void CheckForLeaksCallback(const SuspendedThreadsList &suspended_threads,
static bool CheckForLeaks() {
if (&__lsan_is_turned_off && __lsan_is_turned_off())
return false;
if (initialized_for_pid != internal_getpid()) {
// If process was forked and it had threads we fail to detect references
// from other threads.
Report("WARNING: LeakSanitizer is disabled in forked process.\n");
return false;
}
EnsureMainThreadIDIsCorrect();
CheckForLeaksParam param;
param.success = false;
Expand Down
35 changes: 35 additions & 0 deletions compiler-rt/test/lsan/TestCases/Linux/fork_with_threads.cc
@@ -0,0 +1,35 @@
// Test forked process does not run lsan.
// RUN: %clangxx_lsan %s -o %t && %run %t 2>&1 | FileCheck %s

#include <pthread.h>
#include <stdlib.h>
#include <sys/wait.h>
#include <unistd.h>

static pthread_barrier_t barrier;

// CHECK-NOT: SUMMARY: {{(Leak|Address)}}Sanitizer:
static void *thread_func(void *arg) {
void *buffer = malloc(1337);
pthread_barrier_wait(&barrier);
for (;;)
pthread_yield();
return 0;
}

int main() {
pthread_barrier_init(&barrier, 0, 2);
pthread_t tid;
int res = pthread_create(&tid, 0, thread_func, 0);
pthread_barrier_wait(&barrier);
pthread_barrier_destroy(&barrier);

pid_t pid = fork();
if (pid > 0) {
int status = 0;
waitpid(pid, &status, 0);
}
return 0;
}

// CHECK: WARNING: LeakSanitizer is disabled in forked process

0 comments on commit b89704f

Please sign in to comment.