Skip to content

Commit

Permalink
[sanitizer][fuzzer] Temporarily transition to ZX_TIME_INFINITE_OLD
Browse files Browse the repository at this point in the history
This is a preparation for breaking change when all Zircon calls that
take time as an argument will start using signed valued. We will
transition back to ZX_TIME_INFITINE after all the changes to these
symbols are done and become part of the Fuchsia SDK.

Differential Revision: https://reviews.llvm.org/D49694

llvm-svn: 337802
  • Loading branch information
petrhosek committed Jul 24, 2018
1 parent e2da642 commit b8ab7e8
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 5 deletions.
11 changes: 7 additions & 4 deletions compiler-rt/lib/fuzzer/FuzzerUtilFuchsia.cpp
Expand Up @@ -49,6 +49,9 @@ void CrashTrampolineAsm() __asm__("CrashTrampolineAsm");

namespace {

// TODO(phosek): remove this and replace it with ZX_TIME_INFINITE
#define ZX_TIME_INFINITE_OLD INT64_MAX

// A magic value for the Zircon exception port, chosen to spell 'FUZZING'
// when interpreted as a byte sequence on little-endian platforms.
const uint64_t kFuzzingCrash = 0x474e495a5a5546;
Expand Down Expand Up @@ -234,7 +237,7 @@ void CrashHandler(zx_handle_t *Event) {
"_zx_object_signal");

zx_port_packet_t Packet;
ExitOnErr(_zx_port_wait(Port.Handle, ZX_TIME_INFINITE, &Packet),
ExitOnErr(_zx_port_wait(Port.Handle, ZX_TIME_INFINITE_OLD, &Packet),
"_zx_port_wait");

// At this point, we want to get the state of the crashing thread, but
Expand Down Expand Up @@ -312,8 +315,8 @@ void SetSignalHandler(const FuzzingOptions &Options) {
ExitOnErr(_zx_event_create(0, &Event), "_zx_event_create");

std::thread T(CrashHandler, &Event);
zx_status_t Status =
_zx_object_wait_one(Event, ZX_USER_SIGNAL_0, ZX_TIME_INFINITE, nullptr);
zx_status_t Status = _zx_object_wait_one(Event, ZX_USER_SIGNAL_0,
ZX_TIME_INFINITE_OLD, nullptr);
_zx_handle_close(Event);
ExitOnErr(Status, "_zx_object_wait_one");

Expand Down Expand Up @@ -437,7 +440,7 @@ int ExecuteCommand(const Command &Cmd) {

// Now join the process and return the exit status.
if ((rc = _zx_object_wait_one(ProcessHandle, ZX_PROCESS_TERMINATED,
ZX_TIME_INFINITE, nullptr)) != ZX_OK) {
ZX_TIME_INFINITE_OLD, nullptr)) != ZX_OK) {
Printf("libFuzzer: failed to join '%s': %s\n", Argv[0],
_zx_status_get_string(rc));
return rc;
Expand Down
5 changes: 4 additions & 1 deletion compiler-rt/lib/sanitizer_common/sanitizer_fuchsia.cc
Expand Up @@ -29,6 +29,9 @@

namespace __sanitizer {

// TODO(phosek): remove this and replace it with ZX_TIME_INFINITE
#define ZX_TIME_INFINITE_OLD INT64_MAX

void NORETURN internal__exit(int exitcode) { _zx_process_exit(exitcode); }

uptr internal_sched_yield() {
Expand Down Expand Up @@ -120,7 +123,7 @@ void BlockingMutex::Lock() {
return;
while (atomic_exchange(m, MtxSleeping, memory_order_acquire) != MtxUnlocked) {
zx_status_t status = _zx_futex_wait(reinterpret_cast<zx_futex_t *>(m),
MtxSleeping, ZX_TIME_INFINITE);
MtxSleeping, ZX_TIME_INFINITE_OLD);
if (status != ZX_ERR_BAD_STATE) // Normal race.
CHECK_EQ(status, ZX_OK);
}
Expand Down

0 comments on commit b8ab7e8

Please sign in to comment.