Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix DW_AT_specification handling in DWO files
Summary: We were trying to get a DWARFDIE from a CompileUnit belonging to a DWO file. However, this function does not understand the die encoding used by the DWO files. Instead use GetDIE on the SymbolFileDWARF, which is overriden in DWO to do the right thing. Reviewers: clayborg, tberghammer Subscribers: lldb-commits, ovyalov Differential Revision: http://reviews.llvm.org/D19927 llvm-svn: 268615
- Loading branch information
Showing
6 changed files
with
71 additions
and
1 deletion.
There are no files selected for viewing
5 changes: 5 additions & 0 deletions
5
lldb/packages/Python/lldbsuite/test/python_api/symbol-context/two-files/Makefile
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
LEVEL = ../../../make | ||
|
||
CXX_SOURCES := file1.cpp file2.cpp | ||
|
||
include $(LEVEL)/Makefile.rules |
35 changes: 35 additions & 0 deletions
35
...es/Python/lldbsuite/test/python_api/symbol-context/two-files/TestSymbolContextTwoFiles.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
""" | ||
Test SBSymbolContext APIs. | ||
""" | ||
|
||
from __future__ import print_function | ||
|
||
import os | ||
|
||
import lldb | ||
from lldbsuite.test.decorators import * | ||
from lldbsuite.test.lldbtest import * | ||
from lldbsuite.test import lldbutil | ||
|
||
class SymbolContextTwoFilesTestCase(TestBase): | ||
|
||
mydir = TestBase.compute_mydir(__file__) | ||
|
||
@add_test_categories(['pyapi']) | ||
def test_lookup_by_address(self): | ||
"""Test lookup by address in a module with multiple compilation units""" | ||
self.build() | ||
exe = os.path.join(os.getcwd(), "a.out") | ||
|
||
target = self.dbg.CreateTarget(exe) | ||
self.assertTrue(target, VALID_TARGET) | ||
|
||
module = target.GetModuleAtIndex(0) | ||
self.assertTrue(module.IsValid()) | ||
for symbol_name in ["struct1::f()", "struct2::f()"]: | ||
sc_list = module.FindFunctions(symbol_name, lldb.eSymbolTypeCode) | ||
self.assertTrue(1, sc_list.GetSize()) | ||
symbol_address = sc_list.GetContextAtIndex(0).GetSymbol().GetStartAddress() | ||
self.assertTrue(symbol_address.IsValid()) | ||
sc_by_address = module.ResolveSymbolContextForAddress(symbol_address, lldb.eSymbolContextFunction) | ||
self.assertEqual(symbol_name, sc_by_address.GetFunction().GetName()) |
11 changes: 11 additions & 0 deletions
11
lldb/packages/Python/lldbsuite/test/python_api/symbol-context/two-files/decls.h
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
struct struct1 | ||
{ | ||
static void | ||
f(); | ||
}; | ||
|
||
struct struct2 | ||
{ | ||
static void | ||
f(); | ||
}; |
13 changes: 13 additions & 0 deletions
13
lldb/packages/Python/lldbsuite/test/python_api/symbol-context/two-files/file1.cpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
#include "decls.h" | ||
|
||
void | ||
struct1::f() | ||
{ | ||
} | ||
|
||
int main() | ||
{ | ||
struct1::f(); | ||
struct2::f(); | ||
return 0; | ||
} |
6 changes: 6 additions & 0 deletions
6
lldb/packages/Python/lldbsuite/test/python_api/symbol-context/two-files/file2.cpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
#include "decls.h" | ||
|
||
void | ||
struct2::f() | ||
{ | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters