Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[NewPM] Remove LoopSinkLegacy Pass (#72811)
This pass isn't used anywhere and thus has no test coverage. For these reasons, remove it.
- Loading branch information
1 parent
d715e2c
commit b9975ce
Showing
5 changed files
with
0 additions
and
67 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b9975ce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@boomanaiden154 FYI: This pass was used in Mesa by radeonsi and its deletion caused a build error, see: https://gitlab.freedesktop.org/mesa/mesa/-/issues/10192
b9975ce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That code in mesa needs to be switched to the new pass manager. Though the LoopSink invocation in that pass pipeline is entirely useless anyway, as it is followed by LICM, which will undo anything LoopSink does. So just dropping it is fine in this case. Generally that pass pipeline looks really suspect (running Mem2Reg and then SROA -- wat?)
b9975ce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented on the mesa PR https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26336.