Skip to content

Commit

Permalink
[cmake] Add read-me for the common CMake utils
Browse files Browse the repository at this point in the history
Now that I am adding more things there, I thought it prudent to document
what should and should not go there, and how it is used.

Reviewed By: lebedev.ri

Differential Revision: https://reviews.llvm.org/D116524
  • Loading branch information
Ericson2314 committed Jan 7, 2022
1 parent 028444c commit b99833d
Showing 1 changed file with 53 additions and 0 deletions.
53 changes: 53 additions & 0 deletions cmake/README.md
@@ -0,0 +1,53 @@
# LLVM Common CMake Utils

## What goes here

These are CMake modules to be shared between LLVM projects strictly at build
time. In other words, they must not be included from an installed CMake module,
such as the `Add*.cmake` ones. Modules that are reachable from installed
modules should instead go in `${project}/cmake/modules` of the most upstream
project that use them.

The advantage of not putting these modules in an existing location like
`llvm/cmake/modules` is two-fold:

- Since they are not installed, we don't have to worry about any out-of-tree
downstream usage, and thus there is no need for stability.

- Since they are available as part of the source at build-time, we don't have
to do the usual stand-alone vs combined-build dances, avoiding much
complexity.

## How to use

For tools, please do:

```cmake
if(NOT DEFINED LLVM_COMMON_CMAKE_UTILS)
set(LLVM_COMMON_CMAKE_UTILS ${LLVM_COMMON_CMAKE_UTILS}/../cmake)
endif()
# Add path for custom modules.
list(INSERT CMAKE_MODULE_PATH 0
# project-specific module dirs first
"${LLVM_COMMON_CMAKE_UTILS}/Modules"
)
```

- The `if(NOT DEFINED ...)` guard is there because in combined builds, LLVM
will set this variable. This is useful for legacy builds where projects are
found in `llvm/tools` instead.

- `INSERT ... 0` ensures these new entries are prepended to the front of the
module path, so nothing might shadow them by mistake.

If runtime libs, we skip the `if(NOT DEFINED` part:

```cmake
set(LLVM_COMMON_CMAKE_UTILS ${LLVM_COMMON_CMAKE_UTILS}/../cmake)
... # same as before
```

If `llvm/tools` legacy-style combined builds are deprecated, we should then
skip it everywhere, bringing the tools and runtimes boilerplate back in line.

0 comments on commit b99833d

Please sign in to comment.