Skip to content

Commit

Permalink
[AMDGPU] Mark ds instructions as meybeAtomic
Browse files Browse the repository at this point in the history
These were not recognized as potential atomics by memory legalizer.
The test was working not because legalizer did a right thing, but
because it has skipped all these instructions. When I have fixed
DS desciption test started to fail because region address has
changed from 4 to 2 a while ago.

Differential Revision: https://reviews.llvm.org/D58802

llvm-svn: 355179
  • Loading branch information
rampitec committed Mar 1, 2019
1 parent 9bf43b5 commit bb98841
Show file tree
Hide file tree
Showing 2 changed files with 47 additions and 46 deletions.
1 change: 1 addition & 0 deletions llvm/lib/Target/AMDGPU/DSInstructions.td
Expand Up @@ -18,6 +18,7 @@ class DS_Pseudo <string opName, dag outs, dag ins, string asmOps, list<dag> patt
// Most instruction load and store data, so set this as the default.
let mayLoad = 1;
let mayStore = 1;
let maybeAtomic = 1;

let hasSideEffects = 0;
let SchedRW = [WriteLDS];
Expand Down

0 comments on commit bb98841

Please sign in to comment.