-
Notifications
You must be signed in to change notification settings - Fork 11k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Avoid keeping internal string_views in Twine.
This is a follow-up to https://reviews.llvm.org/D103935 A Twine's internal layout should not depend on which version of the C++ standard is in use. Dynamically linking binaries compiled with two different layouts (eg, --std=c++14 vs --std=c++17) ends up problematic. This change avoids that issue by immediately converting a string_view to a pointer-and-length at the cost of an extra eight-bytes in Twine. Differential Revision: https://reviews.llvm.org/D106186
- Loading branch information
1 parent
84877a0
commit bbbc4f1
Showing
3 changed files
with
27 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters