Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update phi nodes in LowerTypeTests control flow simplification
D33925 added a control flow simplification for -O2 --lto-O0 builds that manually splits blocks and reassigns conditional branches but does not correctly update phi nodes. If the else case being branched to had incoming phi nodes the control-flow simplification would leave phi nodes in that BB with an unhandled predecessor. Patch by Vlad Tsyrklevich! Differential Revision: https://reviews.llvm.org/D36012 llvm-svn: 309621
- Loading branch information
Showing
2 changed files
with
24 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
; Ensure that LowerTypeTests control flow simplification correctly handle phi nodes. | ||
; RUN: opt -S -lowertypetests -lowertypetests-summary-action=import -lowertypetests-read-summary=%S/Inputs/import.yaml < %s | FileCheck %s | ||
|
||
target datalayout = "e-p:64:64" | ||
|
||
declare i1 @llvm.type.test(i8* %ptr, metadata %bitset) nounwind readnone | ||
|
||
; CHECK: define i1 @bytearray7(i8* [[p:%.*]]) | ||
define i1 @bytearray7(i8* %p) { | ||
%x = call i1 @llvm.type.test(i8* %p, metadata !"bytearray7") | ||
br i1 %x, label %t, label %f | ||
|
||
t: | ||
br label %f | ||
|
||
f: | ||
; CHECK: %test = phi i1 [ false, %{{[0-9]+}} ], [ true, %t ], [ false, %0 ] | ||
%test = phi i1 [ false, %0 ], [ true, %t ] | ||
ret i1 %test | ||
} |