Skip to content

Commit

Permalink
clang-format: [JS] for async loops.
Browse files Browse the repository at this point in the history
Summary:
JavaScript supports asynchronous loop iteration in async functions:

    for async (const x of y) ...

Reviewers: djasper

Subscribers: klimek, cfe-commits

Differential Revision: https://reviews.llvm.org/D33193

llvm-svn: 303106
  • Loading branch information
mprobst committed May 15, 2017
1 parent 878715f commit bd49e32
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 3 deletions.
13 changes: 10 additions & 3 deletions clang/lib/Format/TokenAnnotator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -576,9 +576,12 @@ class AnnotatingParser {
}
break;
case tok::kw_for:
if (Style.Language == FormatStyle::LK_JavaScript && Tok->Previous &&
Tok->Previous->is(tok::period))
break;
if (Style.Language == FormatStyle::LK_JavaScript)
if (Tok->Previous && Tok->Previous->is(tok::period))
break;
// JS' for async ( ...
if (CurrentToken->is(Keywords.kw_async))
next();
Contexts.back().ColonIsForRangeExpr = true;
next();
if (!parseParens())
Expand Down Expand Up @@ -2249,6 +2252,10 @@ bool TokenAnnotator::spaceRequiredBefore(const AnnotatedLine &Line,
} else if (Style.Language == FormatStyle::LK_JavaScript) {
if (Left.is(TT_JsFatArrow))
return true;
// for async ( ...
if (Right.is(tok::l_paren) && Left.is(Keywords.kw_async) &&
Left.Previous && Left.Previous->is(tok::kw_for))
return true;
if (Left.is(Keywords.kw_async) && Right.is(tok::l_paren) &&
Right.MatchingParen) {
const FormatToken *Next = Right.MatchingParen->getNextNonComment();
Expand Down
4 changes: 4 additions & 0 deletions clang/lib/Format/UnwrappedLineParser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1635,6 +1635,10 @@ void UnwrappedLineParser::parseForOrWhileLoop() {
assert(FormatTok->isOneOf(tok::kw_for, tok::kw_while, TT_ForEachMacro) &&
"'for', 'while' or foreach macro expected");
nextToken();
// JS' for async ( ...
if (Style.Language == FormatStyle::LK_JavaScript &&
FormatTok->is(Keywords.kw_async))
nextToken();
if (FormatTok->Tok.is(tok::l_paren))
parseParens();
if (FormatTok->Tok.is(tok::l_brace)) {
Expand Down
9 changes: 9 additions & 0 deletions clang/unittests/Format/FormatTestJS.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -548,6 +548,15 @@ TEST_F(FormatTestJS, AsyncFunctions) {
" // Comment.\n"
" return async.then();\n"
"}\n");
verifyFormat("for async (const x of y) {\n"
" console.log(x);\n"
"}\n");
verifyFormat("function asyncLoop() {\n"
" for async (const x of y) {\n"
" console.log(x);\n"
" }\n"
"}\n");

}

TEST_F(FormatTestJS, FunctionParametersTrailingComma) {
Expand Down

0 comments on commit bd49e32

Please sign in to comment.