Skip to content

Commit

Permalink
[DWARFLinker] Prefix debug section names with '.' in the comments. NFC.
Browse files Browse the repository at this point in the history
In DWARFLinker.h, some comments prefix the debug section names
with '.' while others do not.

Reviewed By: dblaikie

Differential Revision: https://reviews.llvm.org/D108519
  • Loading branch information
RamNalamothu committed Aug 26, 2021
1 parent a233f03 commit be19aee
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions llvm/include/llvm/DWARFLinker/DWARFLinker.h
Expand Up @@ -80,7 +80,7 @@ class AddressesMap {
CompileUnit::DIEInfo &Info) = 0;

/// Apply the valid relocations to the buffer \p Data, taking into
/// account that Data is at \p BaseOffset in the debug_info section.
/// account that Data is at \p BaseOffset in the .debug_info section.
///
/// \returns true whether any reloc has been applied.
virtual bool applyValidRelocs(MutableArrayRef<char> Data, uint64_t BaseOffset,
Expand Down Expand Up @@ -109,7 +109,7 @@ class DwarfEmitter {
/// Emit section named SecName with data SecData.
virtual void emitSectionContents(StringRef SecData, StringRef SecName) = 0;

/// Emit the abbreviation table \p Abbrevs to the debug_abbrev section.
/// Emit the abbreviation table \p Abbrevs to the .debug_abbrev section.
virtual void
emitAbbrevs(const std::vector<std::unique_ptr<DIEAbbrev>> &Abbrevs,
unsigned DwarfVersion) = 0;
Expand Down Expand Up @@ -137,25 +137,25 @@ class DwarfEmitter {
virtual void
emitAppleTypes(AccelTable<AppleAccelTableStaticTypeData> &Table) = 0;

/// Emit debug_ranges for \p FuncRange by translating the
/// Emit .debug_ranges for \p FuncRange by translating the
/// original \p Entries.
virtual void emitRangesEntries(
int64_t UnitPcOffset, uint64_t OrigLowPc,
const FunctionIntervals::const_iterator &FuncRange,
const std::vector<DWARFDebugRangeList::RangeListEntry> &Entries,
unsigned AddressSize) = 0;

/// Emit debug_aranges entries for \p Unit and if \p DoRangesSection is true,
/// also emit the debug_ranges entries for the DW_TAG_compile_unit's
/// Emit .debug_aranges entries for \p Unit and if \p DoRangesSection is true,
/// also emit the .debug_ranges entries for the DW_TAG_compile_unit's
/// DW_AT_ranges attribute.
virtual void emitUnitRangesEntries(CompileUnit &Unit,
bool DoRangesSection) = 0;

/// Copy the debug_line over to the updated binary while unobfuscating the
/// Copy the .debug_line over to the updated binary while unobfuscating the
/// file names and directories.
virtual void translateLineTable(DataExtractor LineData, uint64_t Offset) = 0;

/// Emit the line table described in \p Rows into the debug_line section.
/// Emit the line table described in \p Rows into the .debug_line section.
virtual void emitLineTableForUnit(MCDwarfLineTableParams Params,
StringRef PrologueBytes,
unsigned MinInstLength,
Expand All @@ -175,7 +175,7 @@ class DwarfEmitter {
virtual void emitFDE(uint32_t CIEOffset, uint32_t AddreSize, uint32_t Address,
StringRef Bytes) = 0;

/// Emit the debug_loc contribution for \p Unit by copying the entries from
/// Emit the .debug_loc contribution for \p Unit by copying the entries from
/// \p Dwarf and offsetting them. Update the location attributes to point to
/// the new entries.
virtual void emitLocationsForUnit(
Expand All @@ -184,7 +184,7 @@ class DwarfEmitter {
ProcessExpr) = 0;

/// Emit the compilation unit header for \p Unit in the
/// debug_info section.
/// .debug_info section.
///
/// As a side effect, this also switches the current Dwarf version
/// of the MC layer to the one of U.getOrigUnit().
Expand Down Expand Up @@ -695,7 +695,7 @@ class DWARFLinker {
/// Assign an abbreviation number to \p Abbrev
void assignAbbrev(DIEAbbrev &Abbrev);

/// Compute and emit debug_ranges section for \p Unit, and
/// Compute and emit .debug_ranges section for \p Unit, and
/// patch the attributes referencing it.
void patchRangesForUnit(const CompileUnit &Unit, DWARFContext &Dwarf,
const DWARFFile &File) const;
Expand All @@ -706,7 +706,7 @@ class DWARFLinker {

/// Extract the line tables from the original dwarf, extract the relevant
/// parts according to the linked function ranges and emit the result in the
/// debug_line section.
/// .debug_line section.
void patchLineTableForUnit(CompileUnit &Unit, DWARFContext &OrigDwarf,
const DWARFFile &File);

Expand Down Expand Up @@ -753,7 +753,7 @@ class DWARFLinker {
StringMap<uint32_t> EmittedCIEs;

/// Offset of the last CIE that has been emitted in the output
/// debug_frame section.
/// .debug_frame section.
uint32_t LastCIEOffset = 0;

/// Apple accelerator tables.
Expand Down

0 comments on commit be19aee

Please sign in to comment.