[ELF] Remove config->relocatable condition from Symbol::computeBinding

llvm · Jan 16, 2022 · c0fc09a · c0fc09a
1 parent b3cc470
commit c0fc09a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/lld/ELF/Symbols.cpp b/lld/ELF/Symbols.cpp
@@ -268,8 +268,6 @@ MemoryBufferRef LazyArchive::getMemberBuffer() {
 }
 
 uint8_t Symbol::computeBinding() const {
-  if (config->relocatable)
-    return binding;
   if ((visibility != STV_DEFAULT && visibility != STV_PROTECTED) ||
       (versionId == VER_NDX_LOCAL && !isLazy()))
     return STB_LOCAL;

diff --git a/lld/ELF/Writer.cpp b/lld/ELF/Writer.cpp
@@ -1972,7 +1972,8 @@ template <class ELFT> void Writer<ELFT>::finalizeSections() {
     for (Symbol *sym : symtab->symbols()) {
       if (!sym->isUsedInRegularObj || !includeInSymtab(*sym))
         continue;
-      sym->binding = sym->computeBinding();
+      if (!config->relocatable)
+        sym->binding = sym->computeBinding();
       if (in.symTab)
         in.symTab->addSymbol(sym);