Address Feedback nr.2

llvm · May 3, 2024 · c101bc0 · c101bc0
1 parent 248eb26
commit c101bc0
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/lld/MachO/ObjC.cpp b/lld/MachO/ObjC.cpp
@@ -196,10 +196,10 @@ static StringRef getReferentString(const Reloc &r) {
     return s->getStringRefAtOffset(sym->value + r.addend);
 
   if (isa<ConcatInputSection>(sym->isec())) {
-    auto &data = sym->isec()->data;
-    const char *pDataStart = reinterpret_cast<const char *>(data.data());
-    uint32_t len = strnlen(pDataStart + sym->value, data.size() - sym->value);
-    return StringRef(pDataStart + sym->value, len);
+    auto paddedData = sym->isec()->data.slice(sym->value);
+    uint32_t len = strnlen((const char *)paddedData.data(), paddedData.size());
+    auto strData = paddedData.slice(0, len);
+    return StringRef((const char *)strData.data(), strData.size());
   }
 
   llvm_unreachable("unknown reference section in getReferentString");