Skip to content

Commit

Permalink
[AArch64][GlobalISel] Don't allow s128 for G_ISNAN
Browse files Browse the repository at this point in the history
getAPFloatFromSize doesn't support s128, so we can't lower this without
asserting right now.

To fix the buildbots, don't allow any scalars other than s16, s32, and s64.
  • Loading branch information
Jessica Paquette committed Aug 18, 2021
1 parent b2e77cd commit c22b64e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp
Expand Up @@ -727,7 +727,8 @@ AArch64LegalizerInfo::AArch64LegalizerInfo(const AArch64Subtarget &ST)
// TODO: Vector types.
getActionDefinitionsBuilder({G_SADDSAT, G_SSUBSAT}).lowerIf(isScalar(0));

getActionDefinitionsBuilder(G_ISNAN).lower();
getActionDefinitionsBuilder(G_ISNAN).lowerIf(
any(isVector(1), typeInSet(1, {s16, s32, s64})));

// TODO: Vector types.
getActionDefinitionsBuilder({G_FMAXNUM, G_FMINNUM})
Expand Down

0 comments on commit c22b64e

Please sign in to comment.