-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Clang] Handle structs with inner structs and no fields (#89126)
A struct that declares an inner struct, but no fields, won't have a field count. So getting the offset of the inner struct fails. This happens in both C and C++: struct foo { struct bar { int Quantizermatrix[]; }; }; Here 'struct foo' has no fields. Closes: #88931
- Loading branch information
Showing
3 changed files
with
75 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 4 | ||
// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -O2 -Wno-missing-declarations -emit-llvm -o - %s | FileCheck %s | ||
|
||
struct foo { | ||
int x,y,z; | ||
struct bar { | ||
int count; | ||
int array[] __attribute__((counted_by(count))); | ||
}; | ||
}; | ||
|
||
void init(void * __attribute__((pass_dynamic_object_size(0)))); | ||
|
||
// CHECK-LABEL: define dso_local void @test1( | ||
// CHECK-SAME: ptr noundef [[P:%.*]]) local_unnamed_addr #[[ATTR0:[0-9]+]] { | ||
// CHECK-NEXT: entry: | ||
// CHECK-NEXT: [[ARRAY:%.*]] = getelementptr inbounds i8, ptr [[P]], i64 4 | ||
// CHECK-NEXT: tail call void @init(ptr noundef nonnull [[ARRAY]], i64 noundef -1) #[[ATTR2:[0-9]+]] | ||
// CHECK-NEXT: ret void | ||
// | ||
void test1(struct bar *p) { | ||
init(p->array); | ||
} | ||
|
||
struct mux { | ||
int count; | ||
int array[] __attribute__((counted_by(count))); | ||
}; | ||
|
||
struct bux { struct mux x; }; | ||
|
||
// CHECK-LABEL: define dso_local void @test2( | ||
// CHECK-SAME: ptr noundef [[P:%.*]]) local_unnamed_addr #[[ATTR0]] { | ||
// CHECK-NEXT: entry: | ||
// CHECK-NEXT: tail call void @init(ptr noundef [[P]], i64 noundef -1) #[[ATTR2]] | ||
// CHECK-NEXT: ret void | ||
// | ||
void test2(struct bux *p) { | ||
init(p); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 4 | ||
// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -O2 -Wall -emit-llvm -o - %s | FileCheck %s | ||
|
||
struct foo { | ||
struct bar { | ||
int array[]; | ||
bar(); | ||
}; | ||
}; | ||
|
||
void init(void * __attribute__((pass_dynamic_object_size(0)))); | ||
|
||
// CHECK-LABEL: define dso_local void @_ZN3foo3barC1Ev( | ||
// CHECK-SAME: ptr noundef nonnull align 4 dereferenceable(1) [[THIS:%.*]]) unnamed_addr #[[ATTR0:[0-9]+]] align 2 { | ||
// CHECK-NEXT: entry: | ||
// CHECK-NEXT: tail call void @_Z4initPvU25pass_dynamic_object_size0(ptr noundef nonnull [[THIS]], i64 noundef -1) #[[ATTR2:[0-9]+]] | ||
// CHECK-NEXT: ret void | ||
// | ||
foo::bar::bar() { | ||
init(array); | ||
} |