Skip to content

Commit

Permalink
Update libc++ include path detection to use VFS on Linux
Browse files Browse the repository at this point in the history
The DetectLibcxxIncludePath function had been using
llvm::sys::fs::directory_iterator, and this updates it to use
llvm::vfs::directory_iterator.

Differential Revision: https://reviews.llvm.org/D64381

llvm-svn: 365682
  • Loading branch information
Julie Hockett committed Jul 10, 2019
1 parent 1a2c880 commit c327421
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions clang/lib/Driver/ToolChains/Linux.cpp
Expand Up @@ -865,12 +865,13 @@ void Linux::AddClangSystemIncludeArgs(const ArgList &DriverArgs,
addExternCSystemInclude(DriverArgs, CC1Args, SysRoot + "/usr/include");
}

static std::string DetectLibcxxIncludePath(StringRef base) {
static std::string DetectLibcxxIncludePath(llvm::vfs::FileSystem &vfs,
StringRef base) {
std::error_code EC;
int MaxVersion = 0;
std::string MaxVersionString = "";
for (llvm::sys::fs::directory_iterator LI(base, EC), LE; !EC && LI != LE;
LI = LI.increment(EC)) {
for (llvm::vfs::directory_iterator LI = vfs.dir_begin(base, EC), LE;
!EC && LI != LE; LI = LI.increment(EC)) {
StringRef VersionText = llvm::sys::path::filename(LI->path());
int Version;
if (VersionText[0] == 'v' &&
Expand All @@ -888,12 +889,12 @@ void Linux::addLibCxxIncludePaths(const llvm::opt::ArgList &DriverArgs,
llvm::opt::ArgStringList &CC1Args) const {
const std::string& SysRoot = computeSysRoot();
const std::string LibCXXIncludePathCandidates[] = {
DetectLibcxxIncludePath(getDriver().Dir + "/../include/c++"),
DetectLibcxxIncludePath(getVFS(), getDriver().Dir + "/../include/c++"),
// If this is a development, non-installed, clang, libcxx will
// not be found at ../include/c++ but it likely to be found at
// one of the following two locations:
DetectLibcxxIncludePath(SysRoot + "/usr/local/include/c++"),
DetectLibcxxIncludePath(SysRoot + "/usr/include/c++") };
DetectLibcxxIncludePath(getVFS(), SysRoot + "/usr/local/include/c++"),
DetectLibcxxIncludePath(getVFS(), SysRoot + "/usr/include/c++") };
for (const auto &IncludePath : LibCXXIncludePathCandidates) {
if (IncludePath.empty() || !getVFS().exists(IncludePath))
continue;
Expand Down

0 comments on commit c327421

Please sign in to comment.