-
Notifications
You must be signed in to change notification settings - Fork 11k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allow specifying pipe syntax for use-ranges checks
Add `UseReversePipe` option to (boost|modernize)-use-ranges checks. This controls whether to create a reverse view using function syntax (`reverse(Range)`) or pipe syntax (`Range | reverse`)
- Loading branch information
Showing
15 changed files
with
358 additions
and
237 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
clang-tools-extra/test/clang-tidy/checkers/boost/Inputs/use-ranges/fake_boost.h
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
#ifndef USE_RANGES_FAKE_BOOST_H | ||
#define USE_RANGES_FAKE_BOOST_H | ||
|
||
namespace boost { | ||
namespace range_adl_barrier { | ||
|
||
template <typename T> void *begin(T &); | ||
template <typename T> void *end(T &); | ||
template <typename T> void *const_begin(const T &); | ||
template <typename T> void *const_end(const T &); | ||
} // namespace range_adl_barrier | ||
|
||
using namespace range_adl_barrier; | ||
|
||
template <typename T> void *rbegin(T &); | ||
template <typename T> void *rend(T &); | ||
|
||
template <typename T> void *const_rbegin(T &); | ||
template <typename T> void *const_rend(T &); | ||
namespace algorithm { | ||
|
||
template <class InputIterator, class T, class BinaryOperation> | ||
T reduce(InputIterator first, InputIterator last, T init, BinaryOperation bOp) { | ||
return init; | ||
} | ||
} // namespace algorithm | ||
} // namespace boost | ||
|
||
#endif // USE_RANGES_FAKE_BOOST_H |
99 changes: 99 additions & 0 deletions
99
clang-tools-extra/test/clang-tidy/checkers/boost/Inputs/use-ranges/fake_std.h
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,99 @@ | ||
#ifndef USE_RANGES_FAKE_STD_H | ||
#define USE_RANGES_FAKE_STD_H | ||
namespace std { | ||
|
||
template <typename T> class vector { | ||
public: | ||
using iterator = T *; | ||
using const_iterator = const T *; | ||
using reverse_iterator = T*; | ||
using reverse_const_iterator = const T*; | ||
|
||
constexpr const_iterator begin() const; | ||
constexpr const_iterator end() const; | ||
constexpr const_iterator cbegin() const; | ||
constexpr const_iterator cend() const; | ||
constexpr iterator begin(); | ||
constexpr iterator end(); | ||
constexpr reverse_const_iterator rbegin() const; | ||
constexpr reverse_const_iterator rend() const; | ||
constexpr reverse_const_iterator crbegin() const; | ||
constexpr reverse_const_iterator crend() const; | ||
constexpr reverse_iterator rbegin(); | ||
constexpr reverse_iterator rend(); | ||
}; | ||
|
||
template <typename Container> constexpr auto begin(const Container &Cont) { | ||
return Cont.begin(); | ||
} | ||
|
||
template <typename Container> constexpr auto begin(Container &Cont) { | ||
return Cont.begin(); | ||
} | ||
|
||
template <typename Container> constexpr auto end(const Container &Cont) { | ||
return Cont.end(); | ||
} | ||
|
||
template <typename Container> constexpr auto end(Container &Cont) { | ||
return Cont.end(); | ||
} | ||
|
||
template <typename Container> constexpr auto cbegin(const Container &Cont) { | ||
return Cont.cbegin(); | ||
} | ||
|
||
template <typename Container> constexpr auto cend(const Container &Cont) { | ||
return Cont.cend(); | ||
} | ||
// Find | ||
template< class InputIt, class T > | ||
InputIt find(InputIt first, InputIt last, const T& value); | ||
|
||
template <typename Iter> void reverse(Iter begin, Iter end); | ||
|
||
template <class InputIt1, class InputIt2> | ||
bool includes(InputIt1 first1, InputIt1 last1, InputIt2 first2, InputIt2 last2); | ||
|
||
template <class ForwardIt1, class ForwardIt2> | ||
bool is_permutation(ForwardIt1 first1, ForwardIt1 last1, ForwardIt2 first2, | ||
ForwardIt2 last2); | ||
|
||
template <class BidirIt> | ||
bool next_permutation(BidirIt first, BidirIt last); | ||
|
||
inline namespace inline_test{ | ||
|
||
template <class ForwardIt1, class ForwardIt2> | ||
bool equal(ForwardIt1 first1, ForwardIt1 last1, | ||
ForwardIt2 first2, ForwardIt2 last2); | ||
|
||
template <class RandomIt> | ||
void push_heap(RandomIt first, RandomIt last); | ||
|
||
template <class InputIt, class OutputIt, class UnaryPred> | ||
OutputIt copy_if(InputIt first, InputIt last, OutputIt d_first, UnaryPred pred); | ||
|
||
template <class ForwardIt> | ||
ForwardIt is_sorted_until(ForwardIt first, ForwardIt last); | ||
|
||
template <class InputIt> | ||
void reduce(InputIt first, InputIt last); | ||
|
||
template <class InputIt, class T> | ||
T reduce(InputIt first, InputIt last, T init); | ||
|
||
template <class InputIt, class T, class BinaryOp> | ||
T reduce(InputIt first, InputIt last, T init, BinaryOp op) { | ||
// Need a definition to suppress undefined_internal_type when invoked with lambda | ||
return init; | ||
} | ||
|
||
template <class InputIt, class T> | ||
T accumulate(InputIt first, InputIt last, T init); | ||
|
||
} // namespace inline_test | ||
|
||
} // namespace std | ||
|
||
#endif // USE_RANGES_FAKE_STD_H |
18 changes: 18 additions & 0 deletions
18
clang-tools-extra/test/clang-tidy/checkers/boost/use-ranges-pipe.cpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
// RUN: %check_clang_tidy -std=c++14 %s boost-use-ranges %t -check-suffixes=,PIPE \ | ||
// RUN: -config="{CheckOptions: { \ | ||
// RUN: boost-use-ranges.UseReversePipe: true }}" -- -I %S/Inputs/use-ranges/ | ||
// RUN: %check_clang_tidy -std=c++14 %s boost-use-ranges %t -check-suffixes=,NOPIPE -- -I %S/Inputs/use-ranges/ | ||
|
||
// CHECK-FIXES: #include <boost/algorithm/cxx11/is_sorted.hpp> | ||
// CHECK-FIXES: #include <boost/range/adaptor/reversed.hpp> | ||
|
||
#include "fake_std.h" | ||
|
||
void stdLib() { | ||
std::vector<int> I; | ||
std::is_sorted_until(I.rbegin(), I.rend()); | ||
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use a boost version of this algorithm | ||
// CHECK-FIXES-NOPIPE: boost::algorithm::is_sorted_until(boost::adaptors::reverse(I)); | ||
// CHECK-FIXES-PIPE: boost::algorithm::is_sorted_until(I | boost::adaptors::reversed); | ||
|
||
} |
Oops, something went wrong.