Skip to content

Commit

Permalink
[clang codegen] Address review comment on comment in constWithPadding.
Browse files Browse the repository at this point in the history
  • Loading branch information
efriedma-quic committed Mar 25, 2020
1 parent d788814 commit c46a0c0
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion clang/lib/CodeGen/CGDecl.cpp
Expand Up @@ -1075,7 +1075,9 @@ static llvm::Constant *constWithPadding(CodeGenModule &CGM, IsPattern isPattern,
auto *NewArrayTy = llvm::ArrayType::get(NewElemTy, Size);
return llvm::ConstantArray::get(NewArrayTy, Values);
}
// FIXME: Do we need to handle tail padding in vectors?
// FIXME: Add handling for tail padding in vectors. Vectors don't
// have padding between or inside elements, but the total amount of
// data can be less than the allocated size.
return constant;
}

Expand Down

0 comments on commit c46a0c0

Please sign in to comment.