Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[lld/mac] Don't lose "weak ref" bit when doing LTO
Fixes #52778. Probably fixes Chromium crashing on startup on macOS 10.15 (and older) systems when building with LTO, but I haven't verified that yet. Differential Revision: https://reviews.llvm.org/D115949
- Loading branch information
Showing
2 changed files
with
46 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
; REQUIRES: x86 | ||
|
||
; RUN: rm -rf %t; split-file %s %t | ||
|
||
; RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %t/dylib.s -o %t/dylib.o | ||
; RUN: %lld -dylib -lSystem %t/dylib.o -o %t/dylib.dylib | ||
|
||
;; As baseline, compile the .ll file to a real .o file and check behavior. | ||
; RUN: llc -filetype=obj %t/weak-ref.ll -o %t/obj.o | ||
; RUN: %lld -dylib -lSystem %t/obj.o %t/dylib.dylib -o %t/test.obj | ||
; RUN: llvm-objdump --macho --syms %t/test.obj | FileCheck %s --check-prefixes=WEAK-REF | ||
|
||
;; Check that we get the same behavior compiling the .ll file to a bitcode .o | ||
;; file and linking that. | ||
; RUN: opt -module-summary %t/weak-ref.ll -o %t/bitcode.o | ||
; RUN: %lld -dylib -lSystem %t/bitcode.o %t/dylib.dylib -o %t/test.lto | ||
; RUN: llvm-objdump --macho --syms %t/test.lto | FileCheck %s --check-prefixes=WEAK-REF | ||
|
||
; WEAK-REF: SYMBOL TABLE: | ||
; WEAK-REF: w *UND* _my_weak_extern_function | ||
|
||
;--- dylib.s | ||
|
||
.globl _my_weak_extern_function | ||
_my_weak_extern_function: | ||
ret | ||
|
||
;--- weak-ref.ll | ||
target datalayout = "e-m:o-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128" | ||
target triple = "x86_64-apple-macosx10.15.0" | ||
|
||
declare extern_weak void @my_weak_extern_function() | ||
|
||
; Function Attrs: noinline nounwind optnone ssp uwtable | ||
define i32 @bar(i1 zeroext %0) { | ||
entry: | ||
br i1 %0, label %if.then, label %if.end | ||
|
||
if.then: ; preds = %entry | ||
call void @my_weak_extern_function() | ||
br label %if.end | ||
|
||
if.end: ; preds = %if.then, %entry | ||
ret i32 0 | ||
} |