Skip to content

Commit

Permalink
[AArch64] provide strictfp attributes in test file
Browse files Browse the repository at this point in the history
A post-commit review comment on  https://reviews.llvm.org/D107452 pointed out that
https://llvm.org/docs/LangRef.html
says:
"In a function that uses the constrained intrinsics the strictfp attribute is required on all function calls."

Although there are several files across several test directories which don't follow this guidance, it is straightforward to provide this attribute.

Reviewed By: kpn

Differential Revision: https://reviews.llvm.org/D107567
  • Loading branch information
simonwallis2 committed Aug 26, 2021
1 parent 2de051b commit c4dc81e
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions llvm/test/CodeGen/AArch64/fptosi-strictfp.ll
Expand Up @@ -2,22 +2,24 @@
target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128"
target triple = "aarch64-arm-none-eabi"

define i128 @test_fixtfti(fp128 %ld) {
define i128 @test_fixtfti(fp128 %ld) #0 {
; CHECK-LABEL: test_fixtfti:
; CHECK: bl __fixtfti
entry:
%conv = call i128 @llvm.experimental.constrained.fptosi.i128.f128(fp128 %ld, metadata !"fpexcept.strict")
%conv = call i128 @llvm.experimental.constrained.fptosi.i128.f128(fp128 %ld, metadata !"fpexcept.strict") #0
ret i128 %conv
}

declare i128 @llvm.experimental.constrained.fptosi.i128.f128(fp128, metadata)

define i128 @test_fixtftu(fp128 %ld) {
define i128 @test_fixtftu(fp128 %ld) #0 {
; CHECK-LABEL: test_fixtftu:
; CHECK: bl __fixunstfti
entry:
%conv = call i128 @llvm.experimental.constrained.fptoui.i128.f128(fp128 %ld, metadata !"fpexcept.strict")
%conv = call i128 @llvm.experimental.constrained.fptoui.i128.f128(fp128 %ld, metadata !"fpexcept.strict") #0
ret i128 %conv
}

declare i128 @llvm.experimental.constrained.fptoui.i128.f128(fp128, metadata)

attributes #0 = { strictfp }

0 comments on commit c4dc81e

Please sign in to comment.