Skip to content

Commit

Permalink
Revert "[LoongArch] Change 'using namespace llvm;' to 'namespace llvm…
Browse files Browse the repository at this point in the history
… {' in LoongArchTargetParser.cpp. NFC"

This reverts commit 5863214.

Reason to revert:
These changes are inconsistent with the [[https://llvm.org/docs/CodingStandards.html#use-namespace-qualifiers-to-implement-previously-declared-functions|LLVM stype guide]].
  • Loading branch information
SixWeining committed Jul 19, 2023
1 parent 12f35b3 commit c4eb880
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions llvm/lib/TargetParser/LoongArchTargetParser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@

#include "llvm/TargetParser/LoongArchTargetParser.h"

namespace llvm {
namespace LoongArch {
using namespace llvm;
using namespace llvm::LoongArch;

const FeatureInfo AllFeatures[] = {
#define LOONGARCH_FEATURE(NAME, KIND) {NAME, KIND},
Expand All @@ -27,14 +27,15 @@ const ArchInfo AllArchs[] = {
#include "llvm/TargetParser/LoongArchTargetParser.def"
};

bool isValidArchName(StringRef Arch) {
bool LoongArch::isValidArchName(StringRef Arch) {
for (const auto A : AllArchs)
if (A.Name == Arch)
return true;
return false;
}

bool getArchFeatures(StringRef Arch, std::vector<StringRef> &Features) {
bool LoongArch::getArchFeatures(StringRef Arch,
std::vector<StringRef> &Features) {
for (const auto A : AllArchs) {
if (A.Name == Arch) {
for (const auto F : AllFeatures)
Expand All @@ -45,5 +46,3 @@ bool getArchFeatures(StringRef Arch, std::vector<StringRef> &Features) {
}
return false;
}
} // namespace LoongArch
} // namespace llvm

0 comments on commit c4eb880

Please sign in to comment.