Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[yaml2obj] - Do not skip zeroes blocks if there are relocations again…
…st them. This is for -D -reloc combination. With this patch, we do not skip the zero bytes that have a relocation against them when -reloc is used. If -reloc is not used, then the behavior will be the same. Differential revision: https://reviews.llvm.org/D58174 llvm-svn: 354319
- Loading branch information
George Rimar
committed
Feb 19, 2019
1 parent
6947acd
commit c5f2920
Showing
2 changed files
with
68 additions
and
10 deletions.
There are no files selected for viewing
52 changes: 52 additions & 0 deletions
52
llvm/test/tools/llvm-objdump/disasm-zeroes-relocations.test
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
# RUN: yaml2obj %s > %t | ||
|
||
## Check we do not skip zeroes blocks if have relocations pointed to these places. | ||
# RUN: llvm-objdump -D -reloc %t | ||
|
||
# CHECK: Disassembly of section .rodata: | ||
# CHECK-NEXT: 0000000000000000 .rodata: | ||
# CHECK-NEXT: 0: 00 00 addb %al, (%rax) | ||
# CHECK-NEXT: 0000000000000000: R_X86_64_64 *ABS* | ||
# CHECK-NEXT: 2: 00 00 addb %al, (%rax) | ||
# CHECK-NEXT: 4: 00 00 addb %al, (%rax) | ||
# CHECK-NEXT: 6: 00 00 addb %al, (%rax) | ||
# CHECK-NEXT: 8: 00 00 addb %al, (%rax) | ||
# CHECK-NEXT: 0000000000000008: R_X86_64_64 *ABS* | ||
# CHECK-NEXT: a: 00 00 addb %al, (%rax) | ||
# CHECK-NEXT: c: 00 00 addb %al, (%rax) | ||
# CHECK-NEXT: e: 00 00 addb %al, (%rax) | ||
|
||
## Check that without -reloc all zeroes would be omitted. | ||
# RUN: llvm-objdump -D %t | FileCheck %s --check-prefix=SKIP | ||
|
||
# SKIP: Disassembly of section .rodata: | ||
# SKIP-NEXT: 0000000000000000 .rodata: | ||
# SKIP-NEXT: ... | ||
# SKIP-NEXT: Disassembly of section .rela.rodata: | ||
|
||
--- !ELF | ||
FileHeader: | ||
Class: ELFCLASS64 | ||
Data: ELFDATA2LSB | ||
Type: ET_REL | ||
Machine: EM_X86_64 | ||
Sections: | ||
- Name: .rodata | ||
Type: SHT_PROGBITS | ||
Flags: [ SHF_ALLOC ] | ||
AddressAlign: 0x0000000000000001 | ||
Content: '00000000000000000000000000000000' | ||
- Name: .rela.rodata | ||
Type: SHT_RELA | ||
Flags: [ SHF_INFO_LINK ] | ||
Link: .symtab | ||
AddressAlign: 0x0000000000000008 | ||
EntSize: 0x0000000000000018 | ||
Info: .rodata | ||
Relocations: | ||
- Offset: 0x0000000000000000 | ||
Symbol: x | ||
Type: R_X86_64_64 | ||
- Offset: 0x0000000000000008 | ||
Symbol: x | ||
Type: R_X86_64_64 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters