Skip to content

Commit

Permalink
[compiler-rt] Disable some unittests on windows that rely on shell co…
Browse files Browse the repository at this point in the history
…mmand

Summary:
These unittests are not running on windows because they are using incorrect commands.
They were not failing on 32-bits because there is a requirement: asan-64-bits.

```
$ "nm" "C:\src\llvm\ninja64\projects\compiler-rt\test\asan\X86_64WindowsConfig\TestCases\Output\no_asan_gen_globals.c.tmp.exe"
# command stderr:
'nm': command not found
error: command failed with exit status: 127
```

```
$ "rm" "-rf" "C:\src\llvm\ninja64\projects\compiler-rt\test\asan\X86_64WindowsConfig\TestCases\Output/coverage-tracing"
$ "mkdir" "C:\src\llvm\ninja64\projects\compiler-rt\test\asan\X86_64WindowsConfig\TestCases\Output/coverage-tracing"
$ "A=x"
# command stderr:
'A=x': command not found
error: command failed with exit status: 127
```


```
$ "DIR=C:\src\llvm\ninja64\projects\compiler-rt\test\asan\X86_64WindowsConfig\TestCases\Output/coverage-order-pcs"
# command stderr:
'DIR=C:\\src\\llvm\\ninja64\\projects\\compiler-rt\\test\\asan\\X86_64WindowsConfig\\TestCases\\Output/coverage-order-pcs': command not found
error: command failed with exit status: 127
```

Reviewers: rnk

Subscribers: tberghammer, llvm-commits, danalbert, wang0109, srhines, kubabrecka, chrisha

Differential Revision: https://reviews.llvm.org/D22612

llvm-svn: 276290
  • Loading branch information
bergeret committed Jul 21, 2016
1 parent 88e0940 commit c6b0965
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
Expand Up @@ -2,7 +2,6 @@
// XFAIL: android
// FIXME: http://llvm.org/bugs/show_bug.cgi?id=22682
// REQUIRES: asan-64-bits
//
// Make sure __asan_gen_* strings do not end up in the symbol table.

// RUN: %clang_asan %s -o %t.exe
Expand Down
2 changes: 1 addition & 1 deletion compiler-rt/test/asan/TestCases/coverage-order-pcs.cc
Expand Up @@ -19,7 +19,7 @@
//
// RUN: rm -rf $DIR
// Ordering works only in 64-bit mode for now.
// REQUIRES: asan-64-bits
// REQUIRES: asan-64-bits, shell
// UNSUPPORTED: android
#include <stdio.h>

Expand Down
2 changes: 1 addition & 1 deletion compiler-rt/test/asan/TestCases/coverage-tracing.cc
Expand Up @@ -24,7 +24,7 @@
// RUN: not diff b.points bf.points
// RUN: rm -rf %T/coverage-tracing
//
// REQUIRES: asan-64-bits
// REQUIRES: asan-64-bits, shell
// UNSUPPORTED: android

#include <stdlib.h>
Expand Down
2 changes: 2 additions & 0 deletions compiler-rt/test/asan/TestCases/intra-object-overflow.cc
Expand Up @@ -4,6 +4,8 @@
//
// FIXME: fix 32-bits.
// REQUIRES: asan-64-bits
// FIXME: Implement ASan intra-object padding in Clang's MS record layout
// UNSUPPORTED: win32
#include <stdio.h>
#include <stdlib.h>
class Foo {
Expand Down

0 comments on commit c6b0965

Please sign in to comment.