amend! amend! amend! Bump googletest to v1.14.0

Fix unused function issue which breaks a few bots.
llvm · Sep 13, 2023 · c7e1a49 · c7e1a49
1 parent 2fe51a3
commit c7e1a49
Showing 1 changed file with 13 additions and 2 deletions.
diff --git a/third-party/unittest/googletest/include/gtest/gtest-printers.h b/third-party/unittest/googletest/include/gtest/gtest-printers.h
@@ -218,13 +218,24 @@ struct StreamPrinter {
   // ADL (possibly involving implicit conversions).
   // (Use SFINAE via return type, because it seems GCC < 12 doesn't handle name
   // lookup properly when we do it in the template parameter list.)
+
+  // LLVM local change to support llvm printables.
+  //
+  // static auto PrintValue(const T& value, ::std::ostream* os)
+  //     -> decltype((void)(*os << value)) {
+  //   // Call streaming operator found by ADL, possibly with implicit conversions
+  //   // of the arguments.
+  //   // LLVM local change to support llvm printables.
+  //   //
+  //   *os << value;
+  //   // LLVM local change end.
+  // }
   static auto PrintValue(const T& value, ::std::ostream* os)
-      -> decltype((void)(*os << value)) {
+      -> decltype((void)(*os << ::llvm_gtest::printable(value))) {
     // Call streaming operator found by ADL, possibly with implicit conversions
     // of the arguments.
     // LLVM local change to support llvm printables.
     //
-    // *os << value;
     *os << ::llvm_gtest::printable(value);
     // LLVM local change end.
   }